[PATCH] IOMUX: Fix access past end of console_devices

Andy Shevchenko andy.shevchenko at gmail.com
Wed Mar 30 19:13:14 CEST 2022


On Wed, Mar 30, 2022 at 7:49 PM Sean Anderson <seanga2 at gmail.com> wrote:

Also I don't like to have workarounds for the broken tools.
But if you still want to have something, what about rather this

>  #define for_each_console_dev(i, file, dev)             \
> -       for (i = 0, dev = console_devices[file][i];     \
> -            i < cd_count[file];                        \
> -            i++, dev = console_devices[file][i])
> +       for (i = 0; i < cd_count[file] &&               \
> +               (dev = console_devices[file][i]); i++)

       for (i = 0, dev = console_devices[file][0];     \
            i < cd_count[file];                        \
            i++, dev = console_devices[file][i])

?

Or if it's still complains

       for (i = 0, dev = cd_count[file] ? console_devices[file][0] : NULL;     \
            i < cd_count[file];                        \
            i++, dev = console_devices[file][i])

?

-- 
With Best Regards,
Andy Shevchenko


More information about the U-Boot mailing list