[PATCH 09/25] stm32f429-discovery: Migrate CONFIG_*_LED out of CONFIG namespace

Patrice CHOTARD patrice.chotard at foss.st.com
Thu Mar 31 09:20:31 CEST 2022


Hi Tom

On 3/31/22 00:07, Tom Rini wrote:
> These values are only used in one file, reference them more directly.
> 
> Cc: Kamil Lulko <kamil.lulko at gmail.com>
> Cc: Patrick Delaunay <patrick.delaunay at foss.st.com>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: uboot-stm32 at st-md-mailman.stormreply.com
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  board/st/stm32f429-discovery/led.c    | 19 +++++++++++--------
>  include/configs/stm32f429-discovery.h |  3 ---
>  2 files changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/board/st/stm32f429-discovery/led.c b/board/st/stm32f429-discovery/led.c
> index 539c139bb5dd..8dda6a97bd1c 100644
> --- a/board/st/stm32f429-discovery/led.c
> +++ b/board/st/stm32f429-discovery/led.c
> @@ -8,30 +8,33 @@
>  #include <status_led.h>
>  #include <asm-generic/gpio.h>
>  
> +#define RED_LED			110
> +#define GREEN_LED		109
> +
>  void coloured_LED_init(void)
>  {
> -	gpio_request(CONFIG_RED_LED, "red led");
> -	gpio_direction_output(CONFIG_RED_LED, 0);
> -	gpio_request(CONFIG_GREEN_LED, "green led");
> -	gpio_direction_output(CONFIG_GREEN_LED, 0);
> +	gpio_request(RED_LED, "red led");
> +	gpio_direction_output(RED_LED, 0);
> +	gpio_request(GREEN_LED, "green led");
> +	gpio_direction_output(GREEN_LED, 0);
>  }
>  
>  void red_led_off(void)
>  {
> -	gpio_set_value(CONFIG_RED_LED, 0);
> +	gpio_set_value(RED_LED, 0);
>  }
>  
>  void green_led_off(void)
>  {
> -	gpio_set_value(CONFIG_GREEN_LED, 0);
> +	gpio_set_value(GREEN_LED, 0);
>  }
>  
>  void red_led_on(void)
>  {
> -	gpio_set_value(CONFIG_RED_LED, 1);
> +	gpio_set_value(RED_LED, 1);
>  }
>  
>  void green_led_on(void)
>  {
> -	gpio_set_value(CONFIG_GREEN_LED, 1);
> +	gpio_set_value(GREEN_LED, 1);
>  }
> diff --git a/include/configs/stm32f429-discovery.h b/include/configs/stm32f429-discovery.h
> index c9649a085ef1..21bab5aafd54 100644
> --- a/include/configs/stm32f429-discovery.h
> +++ b/include/configs/stm32f429-discovery.h
> @@ -17,9 +17,6 @@
>  
>  #define CONFIG_SYS_MAX_FLASH_SECT	12
>  
> -#define CONFIG_RED_LED			110
> -#define CONFIG_GREEN_LED		109
> -
>  #define CONFIG_SYS_HZ_CLOCK		1000000	/* Timer is clocked at 1MHz */
>  
>  #define CONFIG_SYS_CBSIZE		1024
Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice


More information about the U-Boot mailing list