[PATCH u-boot-marvell 09/19] net: mvneta: Fix unused variable warning if DM_GPIO is disabled

[Ramon Fried]

On Wed, Apr 27, 2022 at 1:42 PM Marek Behún <kabel at kernel.org> wrote:
>
> From: Marek Behún <marek.behun at nic.cz>
>
> The `ret` variable in mvneta_probe() is unused if DM_GPIO is disabled.
>
> Since the variable is used only once after assigning value, we can
> inline the usage and drop the variable.
>
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> ---
>  drivers/net/mvneta.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
> index 19f8145fc0..72789fc5c6 100644
> --- a/drivers/net/mvneta.c
> +++ b/drivers/net/mvneta.c
> @@ -1570,7 +1570,6 @@ static int mvneta_probe(struct udevice *dev)
>         int node = dev_of_offset(dev);
>         void *bd_space;
>         int fl_node;
> -       int ret;
>
>         /*
>          * Allocate buffer area for descs and rx_buffers. This is only
> @@ -1617,8 +1616,8 @@ static int mvneta_probe(struct udevice *dev)
>         }
>
>  #if CONFIG_IS_ENABLED(DM_GPIO)
> -       ret = dev_read_phandle_with_args(dev, "sfp", NULL, 0, 0, &sfp_args);
> -       if (!ret && ofnode_is_enabled(sfp_args.node))
> +       if (!dev_read_phandle_with_args(dev, "sfp", NULL, 0, 0, &sfp_args) &&
> +           ofnode_is_enabled(sfp_args.node))
>                 gpio_request_by_name_nodev(sfp_args.node, "tx-disable-gpio", 0,
>                                            &pp->sfp_tx_disable_gpio, GPIOD_IS_OUT);
>
> --
> 2.35.1
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>