[PATCH u-boot-marvell 19/19] net: mvneta: Drop unneeded macro

[Ramon Fried]

On Wed, Apr 27, 2022 at 1:42 PM Marek Behún <kabel at kernel.org> wrote:
>
> From: Marek Behún <marek.behun at nic.cz>
>
> Macro MVNETA_GMAC_FORCE_LINK_UP can be dropped from value assignment in
> fixed link case, since it's value is written into the register later in
> the function for link-down-to-link-up case. The value is written as
> MVNETA_GMAC_FORCE_LINK_DOWN | MVNETA_GMAC_FORCE_LINK_PASS, and so the
> macro definition can also be dropped.
>
> Signed-off-by: Marek Behún <marek.behun at nic.cz>
> ---
>  drivers/net/mvneta.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
> index 292c364e5e..d2c42c4396 100644
> --- a/drivers/net/mvneta.c
> +++ b/drivers/net/mvneta.c
> @@ -188,7 +188,6 @@ DECLARE_GLOBAL_DATA_PTR;
>  #define MVNETA_GMAC_AUTONEG_CONFIG               0x2c0c
>  #define      MVNETA_GMAC_FORCE_LINK_DOWN         BIT(0)
>  #define      MVNETA_GMAC_FORCE_LINK_PASS         BIT(1)
> -#define      MVNETA_GMAC_FORCE_LINK_UP           (BIT(0) | BIT(1))
>  #define      MVNETA_GMAC_IB_BYPASS_AN_EN         BIT(3)
>  #define      MVNETA_GMAC_CONFIG_MII_SPEED        BIT(5)
>  #define      MVNETA_GMAC_CONFIG_GMII_SPEED       BIT(6)
> @@ -1175,8 +1174,7 @@ static void mvneta_adjust_link(struct udevice *dev)
>                  */
>                 if (CONFIG_IS_ENABLED(PHY_FIXED) &&
>                     pp->phydev->phy_id == PHY_FIXED_ID)
> -                       val = MVNETA_GMAC_FORCE_LINK_UP |
> -                             MVNETA_GMAC_IB_BYPASS_AN_EN |
> +                       val = MVNETA_GMAC_IB_BYPASS_AN_EN |
>                               MVNETA_GMAC_SET_FC_EN |
>                               MVNETA_GMAC_ADVERT_FC_EN |
>                               MVNETA_GMAC_SAMPLE_TX_CFG_EN;
> --
> 2.35.1
>
Reviewed-by: Ramon Fried <rfried.dev at gmail.com>