[PATCH 1/6] Revert "Convert CONFIG_SYS_BR0_PRELIM et al to Kconfig"
Tom Rini
trini at konsulko.com
Sun May 1 16:39:39 CEST 2022
On Sun, May 01, 2022 at 04:23:52PM +0200, Pali Rohár wrote:
> This reverts commit c7fad78ec0ee41b72a58bebb61959570eb937ab1.
>
> This commit made configuration, understanding, maintenance, debugging and
> future development of the powerpc/mpc85xx Local Bus Controller on P1/P2
> boards impossible.
>
> All preliminary Base and Option registers depends on other code and C
> macros generated at C compile time and they comes from the other macros.
>
> For example, NOR base address and NOR options are set via macros
> CONFIG_SYS_FLASH_BR_PRELIM and CONFIG_SYS_FLASH_OR_PRELIM. And then based
> on other logic are filled correct values in to the correct macros
> CONFIG_SYS_BR*_PRELIM and CONFIG_SYS_OR*_PRELIM.
>
> These config options are not user configurable options and therefore
> should not appear in menuconfig. Moreover for P1/P2 boards they have
> nothing with DDR driver, so they should not appear in drivers/ddr.
>
> This change was completely wrong direction, so revert it. It allows to
> start fixing issues with FLASH, NOR, NAND and CPLD LBC configuration.
> In current state it is impossible.
>
> See also thread for more details:
> https://lore.kernel.org/u-boot/20220426181740.o2n7xfg46ytljcdx@pali/t/#u
>
> Signed-off-by: Pali Rohár <pali at kernel.org>
NAK. We are not moving things back in to board config headers under
CONFIG namespace. Some other solution is required.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220501/c9471a97/attachment.sig>
More information about the U-Boot
mailing list