[PATCH 1/2] ARM: stm32: Use default CONFIG_TFTP_BLOCKSIZE on DHSOM

[Patrick DELAUNAY]

Hi Marek,

On 5/1/22 18:43, Marek Vasut wrote:
> The DHCOM does ship with KS8851 with 1.5 kiB packet buffer. The DHSOM
> may be extended with other MAC options connected to FMC2 bus, like the
> DM9000, wih similar limitations. Use default CONFIG_TFTP_BLOCKSIZE of
> 1468 Bytes instead of 1536 Bytes, which always avoids overflowing the
> packet buffers of such limited MACs, which leads to e.g. TFTP timeouts.
> This also avoids receiving a short packet fragment at the end of each
> TFTP block, which led to reduced performance.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Patrick Delaunay <patrick.delaunay at foss.st.com>
> Cc: Patrice Chotard <patrice.chotard at foss.st.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> ---
>   configs/stm32mp15_dhcom_basic_defconfig | 1 -
>   configs/stm32mp15_dhcor_basic_defconfig | 1 -
>   2 files changed, 2 deletions(-)
>
> diff --git a/configs/stm32mp15_dhcom_basic_defconfig b/configs/stm32mp15_dhcom_basic_defconfig
> index ec955eae200..0ff015cae49 100644
> --- a/configs/stm32mp15_dhcom_basic_defconfig
> +++ b/configs/stm32mp15_dhcom_basic_defconfig
> @@ -80,7 +80,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y
> diff --git a/configs/stm32mp15_dhcor_basic_defconfig b/configs/stm32mp15_dhcor_basic_defconfig
> index 387e068155e..83614b9fc8e 100644
> --- a/configs/stm32mp15_dhcor_basic_defconfig
> +++ b/configs/stm32mp15_dhcor_basic_defconfig
> @@ -77,7 +77,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>   CONFIG_SPL_ENV_IS_NOWHERE=y
>   CONFIG_NET_RANDOM_ETHADDR=y
>   CONFIG_IP_DEFRAG=y
> -CONFIG_TFTP_BLOCKSIZE=1536
>   CONFIG_STM32_ADC=y
>   CONFIG_SPL_BLOCK_CACHE=y
>   CONFIG_DFU_MMC=y



Reviewed-by: Patrick Delaunay <patrick.delaunay at foss.st.com>

Thanks
Patrick