[PATCH v7 4/7] fpga: xilinx: add missed identifier names

Michal Simek michal.simek at xilinx.com
Tue May 3 09:43:25 CEST 2022



On 4/11/22 20:00, Adrian Fiergolski wrote:
> From: Oleksandr Suvorov <oleksandr.suvorov at foundries.io>
> 
> Function definition arguments should also have identifier names.
> Add missed ones to struct xilinx_fpga_op callbacks, unifying code.
> 
> Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov at foundries.io>

missing your sob line here.

M

> ---
>   include/xilinx.h | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/include/xilinx.h b/include/xilinx.h
> index 57b0e7be11..06ecc9a842 100644
> --- a/include/xilinx.h
> +++ b/include/xilinx.h
> @@ -48,12 +48,14 @@ typedef struct {		/* typedef xilinx_desc */
>   } xilinx_desc;			/* end, typedef xilinx_desc */
>   
>   struct xilinx_fpga_op {
> -	int (*load)(xilinx_desc *, const void *, size_t, bitstream_type);
> -	int (*loadfs)(xilinx_desc *, const void *, size_t, fpga_fs_info *);
> +	int (*load)(xilinx_desc *desc, const void *buf, size_t bsize,
> +		    bitstream_type bstype);
> +	int (*loadfs)(xilinx_desc *desc, const void *buf, size_t bsize,
> +		      fpga_fs_info *fpga_fsinfo);
>   	int (*loads)(xilinx_desc *desc, const void *buf, size_t bsize,
>   		     struct fpga_secure_info *fpga_sec_info);
> -	int (*dump)(xilinx_desc *, const void *, size_t);
> -	int (*info)(xilinx_desc *);
> +	int (*dump)(xilinx_desc *desc, const void *buf, size_t bsize);
> +	int (*info)(xilinx_desc *desc);
>   };
>   
>   /* Generic Xilinx Functions


More information about the U-Boot mailing list