[PATCH 1/1] dm: fix DM_EVENT dependencies

Tom Rini trini at konsulko.com
Wed May 4 16:27:53 CEST 2022


On Wed, May 04, 2022 at 08:06:12AM +0200, Heinrich Schuchardt wrote:
> 
> 
> On 5/3/22 21:35, Tom Rini wrote:
> > On Tue, May 03, 2022 at 09:18:33PM +0200, Heinrich Schuchardt wrote:
> > 
> > > CONFIG_DM_EVENT without CONFIG_EVENT is non-functional. Select instead
> > > of imply CONFIG_EVENT.
> > > 
> > > Remove superfluous stub in include/event.h.
> > > 
> > > Fixes: 5b896ed5856f ("event: Add events for device probe/remove")
> > > Reported-by: Jan Kiszka <jan.kiszka at siemens.com>
> > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > > ---
> > >   drivers/core/Kconfig | 2 +-
> > >   include/event.h      | 7 +------
> > >   2 files changed, 2 insertions(+), 7 deletions(-)
> > 
> > I don't think it makes sense to have two symbols at all.  It's part of
> > DM, it should always be DM_EVENT I suppose.
> 
> The event EVT_MISC_INIT_F is used outside of the driver model.
> 
> arch/sandbox/cpu/start.c:127:EVENT_SPY(EVT_MISC_INIT_F,
> sandbox_misc_init_f);
> board/google/chromebook_coral/coral.c:60:EVENT_SPY(EVT_MISC_INIT_F,
> coral_check_ll_boot);
> board/keymile/kmcent2/kmcent2.c:213:EVENT_SPY(EVT_MISC_INIT_F,
> kmcent2_misc_init_f);
> board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c:120:EVENT_SPY(EVT_MISC_INIT_F,
> pg_wcom_misc_init_f);

Oh, I see now.  But then DM_EVENT needs to depend on EVENT.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220504/8eea1fd6/attachment.sig>


More information about the U-Boot mailing list