[PATCH v2 3/9] spl: Convert fat to spl_load

[Sean Anderson]

Hi Tom,

On 5/4/22 8:06 PM, Tom Rini wrote:
> On Fri, Apr 22, 2022 at 02:27:41PM -0400, Sean Anderson wrote:
> 
>> This converts the fat loader to use spl_load.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson at seco.com>
>> Reviewed-by: Stefan Roese <sr at denx.de>
> 
> On am335x_evm_defconfig, and booting from a FAT SD card I see:
> Trying to boot from MMC1
> spl_load_image_fat: error reading image u-boot.img, err - 0
> SPL: failed to boot from all boot devices
> ### ERROR ### Please RESET the board ###

Looks like spl_load_image_fat was expecting bytes read and
not an errno (and so turned your success into a failure). Will fix.

> Note that while not _this_ patch (but likely the one for raw) breaks
> booting from my mx6cuboxi via SD card with:
> Trying to boot from MMC1
> [hang]
> 

Hm, if there's a problem you should at least see
"mmc_load_image_raw_sector: mmc block read error\n"

Could you enable DEBUG in common/spl/spl.c and common/spl/spl_mmc.c?

--Sean