[PATCH 5/5] arm: mvebu: turris_omnia: Fix DEBUG_UART_BASE

[Pali Rohár]

On Friday 06 May 2022 14:30:22 Pali Rohár wrote:
> On Friday 06 May 2022 14:21:02 Stefan Roese wrote:
> > On 06.05.22 11:05, Pali Rohár wrote:
> > > Internal registers in SPL are at address 0xd0000000 and in proper U-Boot at
> > > address 0xf1000000. UART base address is located in internal registers.
> > > 
> > > Fix DEBUG_UART_BASE option to correct value for both SPL and proper U-Boot.
> > > 
> > > This change fixes hangup of proper U-Boot when it is trying to print
> > > something via debug UART.
> > > 
> > > Signed-off-by: Pali Rohár <pali at kernel.org>
> > > ---
> > >   configs/turris_omnia_defconfig | 3 ++-
> > >   1 file changed, 2 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> > > index 217e2603fdfb..62c9be29c86b 100644
> > > --- a/configs/turris_omnia_defconfig
> > > +++ b/configs/turris_omnia_defconfig
> > > @@ -18,7 +18,7 @@ CONFIG_DEFAULT_DEVICE_TREE="armada-385-turris-omnia"
> > >   CONFIG_SPL_TEXT_BASE=0x40000030
> > >   CONFIG_SPL_SERIAL=y
> > >   CONFIG_SPL=y
> > > -CONFIG_DEBUG_UART_BASE=0xd0012000
> > > +CONFIG_DEBUG_UART_BASE=0xf1012000
> > >   CONFIG_DEBUG_UART_CLOCK=250000000
> > >   CONFIG_SYS_LOAD_ADDR=0x800000
> > >   CONFIG_DEBUG_UART=y
> > > @@ -93,6 +93,7 @@ CONFIG_PCI_MVEBU=y
> > >   CONFIG_DM_RTC=y
> > >   CONFIG_RTC_ARMADA38X=y
> > >   CONFIG_SCSI=y
> > > +CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
> > >   CONFIG_DEBUG_UART_SHIFT=2
> > >   CONFIG_SYS_NS16550=y
> > >   CONFIG_KIRKWOOD_SPI=y
> > 
> > Isn't such a change now needed for all 32bit Armada MVEBU targets?
> 
> This is a good question. It should be fixed for all 32bit mvebu targets.

Now I sent additional patch which fixes this for all other 32bit mvebu
platforms which have CONFIG_DEBUG_UART_BASE in defconfig file.

> > Viele Grüße,
> > Stefan Roese
> > 
> > -- 
> > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr at denx.de