[PATCH v2 1/2] common: spl: spl_spi: add support for dynamic override of sf bus

Heiko Schocher hs at denx.de
Wed May 11 10:24:12 CEST 2022


Hello Achath,

On 11.05.22 08:03, Vaishnav Achath wrote:
> Currently the SPI flash to load from is defined through the compile
> time config CONFIG_SF_DEFAULT_BUS and CONFIG_SF_DEFAULT_CS, this
> prevents the loading of binaries from different SPI flash using the
> same build.E.g. supporting QSPI flash boot and OSPI flash boot
> on J721E platform is not possible due to this limitation.
> 
> This commit adds lookup functions spl_spi_boot_bus()
> and spl_spi_boot_cs for identifying the flash device based on the
> selected boot device, when not overridden the lookup functions are
> weakly defined in common/spl/spl_spi.c.
> 
> Signed-off-by: Vaishnav Achath <vaishnav.a at ti.com>
> ---

you miss here change history. May you want to look into patman tool in

u-boot:/tools/patman/README

which can help you here much.

>  common/spl/spl_spi.c | 16 +++++++++++++---
>  include/spl.h        | 16 ++++++++++++++++
>  2 files changed, 29 insertions(+), 3 deletions(-)

Looks fine for me, thanks!

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list