[PATCH] mmc: fsl_esdhc_spl: Fix checking for number of read sectors

Jaehoon Chung jh80.chung at samsung.com
Tue May 17 01:41:23 CEST 2022


On 5/12/22 03:28, Pali Rohár wrote:
> Commit 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy
> support") changed number of sectors which are read but did not adjusted
> error check.
> 
> Fix it and check for if correct number of sectors were read.
> 
> Fixes: 0980cbba7b3c ("mmc: fsl_esdhc_spl: pre-PBL: implement redundancy support")
> Signed-off-by: Pali Rohár <pali at kernel.org>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/fsl_esdhc_spl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc_spl.c b/drivers/mmc/fsl_esdhc_spl.c
> index ea8f4cd66964..760f13d24018 100644
> --- a/drivers/mmc/fsl_esdhc_spl.c
> +++ b/drivers/mmc/fsl_esdhc_spl.c
> @@ -106,7 +106,7 @@ again:
>  	blk_off = (sector * 512) % mmc->read_bl_len;
>  	blk_cnt = DIV_ROUND_UP(512,  mmc->read_bl_len);
>  	err = mmc->block_dev.block_read(&mmc->block_dev, blk_start, blk_cnt, tmp_buf);
> -	if (err != 1) {
> +	if (err != blk_cnt) {
>  		puts("spl: mmc read failed!!\n");
>  		hang();
>  	}



More information about the U-Boot mailing list