[PATCH] phy: Fix phy_string_for_interface() function

Vladimir Oltean vladimir.oltean at nxp.com
Thu May 19 15:03:43 CEST 2022


On Thu, May 19, 2022 at 02:49:12PM +0200, Pali Rohár wrote:
> Commit c677fb1e3196 ("phy: Move PHY_INTERFACE_MODE_NA to the beginning of
> the enum definition") broke function phy_string_for_interface(). And
> therefore completely broke support for 2500base-x mode in Armada 3720
> comphy driver.
> 
> Since that commit function phy_string_for_interface() returns constant
> value PHY_INTERFACE_MODE_NA because PHY_INTERFACE_MODE_NA from moved from
> end to the beginning.
> 
> Previous value of PHY_INTERFACE_MODE_NA was PHY_INTERFACE_MODE_MAX-1. So
> change phy_string_for_interface() code to check upper bound via previous
> value.
> 
> This patch fixes 2500base-x mode on Armada 3720
> 
> Fixes: c677fb1e3196 ("phy: Move PHY_INTERFACE_MODE_NA to the beginning of the enum definition")
> Signed-off-by: Pali Rohár <pali at kernel.org>
> ---

Ramon, can you please apply this patch, since people are hitting the issue?
https://patchwork.ozlabs.org/project/uboot/patch/20220510224910.12553-1-tharvey@gateworks.com/


More information about the U-Boot mailing list