[PATCH] common/board_r.c: drop legacy and unused bi_enetaddr

Tom Rini trini at konsulko.com
Fri May 20 17:20:26 CEST 2022


On Fri, May 20, 2022 at 01:19:08PM +0200, Rasmus Villemoes wrote:

> The bi_enetaddr field in struct bd_info is write-only; nothing ever
> reads back the value.
> 
> Moreover, the value we write is more or less random, and certainly not
> something one can rely on: If the board has a writable environment and
> the mac address has been stored there, we fetch that value. But if the
> board doesn't, this code runs before initr_net() -> eth_initialize(),
> and thus before the code in eth-uclass which fetches MAC addresses
> from eeprom, fuses or whatnot and populates the (run-time) environment
> with those values.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>

I believe in this case legacy means non-device tree PowerPC Linux (and
perhaps VxWorks?) since for ARM we would pass in ATAGS stuff instead but
PowerPC we did do gd?  Been so long...

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220520/734cd451/attachment.sig>


More information about the U-Boot mailing list