[PATCH] fpga: intel_sdm_mb: Add checking for INTEL_SIP_SMC_STATUS_BUSY (1)

Chee, Tien Fong tien.fong.chee at intel.com
Tue May 24 12:28:54 CEST 2022



> -----Original Message-----
> From: Maniyam, Dinesh <dinesh.maniyam at intel.com>
> Sent: Monday, 9 May, 2022 3:43 PM
> To: u-boot at lists.denx.de
> Cc: Michal Simek <michal.simek at amd.com>; Chee, Tien Fong
> <tien.fong.chee at intel.com>; Hea, Kok Kiang <kok.kiang.hea at intel.com>;
> Gan, Yau Wai <yau.wai.gan at intel.com>; Kho, Sin Hui
> <sin.hui.kho at intel.com>; Lokanathan, Raaj <raaj.lokanathan at intel.com>;
> Maniyam, Dinesh <dinesh.maniyam at intel.com>; Ley Foon Tan
> <ley.foon.tan at intel.com>
> Subject: [PATCH] fpga: intel_sdm_mb: Add checking for
> INTEL_SIP_SMC_STATUS_BUSY (1)
> 
> From: Dinesh Maniyam <dinesh.maniyam at intel.com>
> 
> Status busy means transfer is accepted but SDM does not have more freed
> buffer. It is not an error. Continue process the data if receive OK and BUSY
> status.

Can you help to improve the commit message? That is not possible wr_ret would return with two results(OK and BUSY) in status at the same time. Please change to "OK or Busy status".

Please extend the years of copyright to "2018-2022"

> 
> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
> Signed-off-by: Dinesh Maniyam <dinesh.maniyam at intel.com>
> ---
>  drivers/fpga/intel_sdm_mb.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/fpga/intel_sdm_mb.c b/drivers/fpga/intel_sdm_mb.c
> index f5fd9a14c2..5e0b2777e0 100644
> --- a/drivers/fpga/intel_sdm_mb.c
> +++ b/drivers/fpga/intel_sdm_mb.c
> @@ -70,7 +70,8 @@ static int send_bitstream(const void *rbf_data, size_t
> rbf_size)
>  			debug("wr_ret = %d, rbf_data = %p, buf_size
> = %08lx\n",
>  			      wr_ret, rbf_data, buf_size);
> 
> -			if (wr_ret)
> +			if (wr_ret != INTEL_SIP_SMC_STATUS_OK &&
> +				wr_ret != INTEL_SIP_SMC_STATUS_BUSY)

Alignment issue after "(" above, please run the checkpatch.pl

>  				continue;
> 
>  			rbf_size -= buf_size;
> --
> 2.26.2



More information about the U-Boot mailing list