[PATCH v2 0/8] imx8: switch missing boards to binman

Stefano Babic sbabic at denx.de
Wed Nov 9 16:44:43 CET 2022


Hi Fabio,

On 08.11.22 23:16, Fabio Estevam wrote:
> Hi Oliver and Stefano,
> 
> On Tue, Nov 8, 2022 at 1:43 PM Stefano Babic <sbabic at denx.de> wrote:
> 
>> I have tried to merge the series, but I get build errors, see:
>>
>> https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/519510
>>
>> Could you take a look ?
> 
> One problem I noticed is the missing CONFIG_TEXT_BASE conversion:
> 
> diff --git a/arch/arm/dts/imx8qm-u-boot.dtsi b/arch/arm/dts/imx8qm-u-boot.dtsi
> index 3507489a813c..442e64badc39 100644
> --- a/arch/arm/dts/imx8qm-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qm-u-boot.dtsi
> @@ -50,7 +50,7 @@
>                                          arch = "arm64";
>                                          compression = "none";
>                                          description = "U-Boot (64-bit)";
> -                                       load = <CONFIG_SYS_TEXT_BASE>;
> +                                       load = <CONFIG_TEXT_BASE>;
>                                          type = "standalone";
> 
>                                          uboot-blob {
> diff --git a/arch/arm/dts/imx8qxp-u-boot.dtsi b/arch/arm/dts/imx8qxp-u-boot.dtsi
> index 01183f8ade63..e8df5bb8bfea 100644
> --- a/arch/arm/dts/imx8qxp-u-boot.dtsi
> +++ b/arch/arm/dts/imx8qxp-u-boot.dtsi
> @@ -50,7 +50,7 @@
>                                          arch = "arm64";
>                                          compression = "none";
>                                          description = "U-Boot (64-bit)";
> -                                       load = <CONFIG_SYS_TEXT_BASE>;
> +                                       load = <CONFIG_TEXT_BASE>;
>                                          type = "standalone";
> 
>                                          uboot-blob {
> 
> With this fix applied, I got:
> 
> WARNING './ahab-container.img' not found, resulting binary is not-functional
> make[1]: Nothing to be done for 'SPL'.
>    BINMAN  all
> binman: Error 1 running 'mkimage -d ./mkimage.spl.mkimage -n
> spl/u-boot-spl.cfgout -T imx8image -e 0x100000
> ./mkimage-out.spl.mkimage': Fail open first container file
> ahab-container.img
> 

This is normal, but CI creates fakes. Most of built boards have warnings 
that build does not run. It is nopt a problem.

> make: *** [Makefile:1116: all] Error 1
> 
> 
> but if I manually copy the firmware, then the build succeeds.
> 
> binman should not thrown an error in case of missing firmware. Oliver,
> any ideas?
> 
> Also, some boards use ahab-container.img and others use
> mx8qxc0-ahab-container.img.
> 
> Is it OK to use mx8qxc0-ahab-container.img for all of them?


I try a CI run with this fixed applied and I let you know.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================



More information about the U-Boot mailing list