[PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

[Fabio Estevam]

Hi Tim,

On Tue, Oct 4, 2022 at 12:26 PM Tim Harvey <tharvey at gateworks.com> wrote:

> Fabio,
>
> Thanks for testing this. I'll submit a v5 shortly with your rb tag and
> support for 6320:

Thanks for including the 6320 model!

> Was there an error path you found in drivers/net/mv88e6xxx.c that
> should print an error to explain a failed probe for better future
> troubleshooting or was that failure somewhere else? It sounds like
> your switch was held in reset such that register reads were failing.

Yes, that was the reason for the register read failure.

Initially, I had described the reset GPIO inside using reset-gpios inside
the switch node, just like described in the Linux binding document:
Documentation/devicetree/bindings/net/dsa/marvell.txt

It did not work, so I moved it to phy-reset-gpios inside the fec node.

I don't think this is a blocker for your v5 series. We can improve it
later so that
the binding from Linux could also work in U-Boot.

Thanks