[PATCH v4 8/8] board: gw_ventana: enable MV88E61XX DSA support

[Tim Harvey]

On Mon, Oct 3, 2022 at 5:39 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> Hi Tim,
>
> On Mon, Oct 3, 2022 at 9:23 PM Tim Harvey <tharvey at gateworks.com> wrote:
>
> > Where are you setting your active port? By default eth0 is active and
> > thats the cpu uplink. If you have a network connection on lan3 port
> > you would need to 'setenv ethact lan3'.
>
> It works now: both 'dhcp' and 'tftp' commands are functional.
>
> Thanks a lot for your work on this and for your help!
>
> If you send a v5 with the CONFIG_MV88E6XXX=y typo fixed,
> feel free to add for the whole series:
>
> Reviewed-by: Fabio Estevam <festevam at denx.de>

Fabio,

Thanks for testing this. I'll submit a v5 shortly with your rb tag and
support for 6320:
--- a/drivers/net/mv88e6xxx.c
+++ b/drivers/net/mv88e6xxx.c
@@ -176,6 +176,7 @@
 #define PORT_SWITCH_ID_6220            0x2200
 #define PORT_SWITCH_ID_6240            0x2400
 #define PORT_SWITCH_ID_6250            0x2500
+#define PORT_SWITCH_ID_6320            0x1150
 #define PORT_SWITCH_ID_6352            0x3520

 struct mv88e6xxx_priv {
@@ -792,6 +793,7 @@ static int mv88e6xxx_probe(struct udevice *dev)
        case PORT_SWITCH_ID_6071:
        case PORT_SWITCH_ID_6220:
        case PORT_SWITCH_ID_6250:
+       case PORT_SWITCH_ID_6320:
                priv->port_count = 7;
                priv->phy_ctrl1_en_det_shift = 14;
                priv->phy_ctrl1_en_det_width = 1;


Was there an error path you found in drivers/net/mv88e6xxx.c that
should print an error to explain a failed probe for better future
troubleshooting or was that failure somewhere else? It sounds like
your switch was held in reset such that register reads were failing.

Best Regards,

Tim