[PATCH v2 1/6] net: mvneta: Add support for AlleyCat5
Chris Packham
judge.packham at gmail.com
Wed Sep 21 03:04:02 CEST 2022
On Tue, Sep 20, 2022 at 9:17 PM Stefan Roese <sr at denx.de> wrote:
>
> On 20.09.22 10:31, Chris Packham wrote:
> > Add support for the AlleyCat5 SoC. This lacks the mbus from the other
> > users of the mvneta.c driver so a new compatible string is needed to
> > allow for a different window configuration.
> >
> > Signed-off-by: Chris Packham <judge.packham at gmail.com>
> > ---
> >
> > (no changes since v1)
> >
> > drivers/net/Kconfig | 2 +-
> > drivers/net/mvneta.c | 66 ++++++++++++++++++++++++++++++++++++++++++--
> > 2 files changed, 64 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 6bbbadc5ee..8df3dce6df 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -448,7 +448,7 @@ config MVGBE
> >
> > config MVNETA
> > bool "Marvell Armada XP/385/3700 network interface support"
> > - depends on ARMADA_XP || ARMADA_38X || ARMADA_3700
> > + depends on ARMADA_XP || ARMADA_38X || ARMADA_3700 || ALLEYCAT_5
> > select PHYLIB
> > select DM_MDIO
> > help
> > diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
> > index d2c42c4396..07919d6d35 100644
> > --- a/drivers/net/mvneta.c
> > +++ b/drivers/net/mvneta.c
> > @@ -91,6 +91,8 @@ DECLARE_GLOBAL_DATA_PTR;
> > #define MVNETA_WIN_SIZE_MASK (0xffff0000)
> > #define MVNETA_BASE_ADDR_ENABLE 0x2290
> > #define MVNETA_BASE_ADDR_ENABLE_BIT 0x1
> > +#define MVNETA_AC5_CNM_DDR_TARGET 0x2
> > +#define MVNETA_AC5_CNM_DDR_ATTR 0xb
> > #define MVNETA_PORT_ACCESS_PROTECT 0x2294
> > #define MVNETA_PORT_ACCESS_PROTECT_WIN0_RW 0x3
> > #define MVNETA_PORT_CONFIG 0x2400
> > @@ -282,6 +284,8 @@ struct mvneta_port {
> > struct gpio_desc phy_reset_gpio;
> > struct gpio_desc sfp_tx_disable_gpio;
> > #endif
> > +
> > + uintptr_t dma_base; /* base address for DMA address decoding */
> > };
> >
> > /* The mvneta_tx_desc and mvneta_rx_desc structures describe the
> > @@ -513,10 +517,19 @@ static void mvneta_rxq_desc_num_update(struct mvneta_port *pp,
> > static struct mvneta_rx_desc *
> > mvneta_rxq_next_desc_get(struct mvneta_rx_queue *rxq)
> > {
> > + struct mvneta_rx_desc *curr;
> > int rx_desc = rxq->next_desc_to_proc;
> >
> > + /* validate RX descriptor */
> > + curr = rxq->descs + rx_desc;
> > + if (curr->data_size == 0) {
> > + /* do it to read real descriptor next time */
> > + DSB;
> > + return NULL;
> > + }
> > +
> > rxq->next_desc_to_proc = MVNETA_QUEUE_NEXT_DESC(rxq, rx_desc);
> > - return rxq->descs + rx_desc;
> > + return curr;
> > }
> >
> > /* Tx descriptors helper methods */
> > @@ -1343,6 +1356,29 @@ static void mvneta_conf_mbus_windows(struct mvneta_port *pp)
> > mvreg_write(pp, MVNETA_BASE_ADDR_ENABLE, win_enable);
> > }
> >
> > +static void mvneta_conf_ac5_cnm_xbar_windows(struct mvneta_port *pp)
> > +{
> > + int i;
> > +
> > + /* Clear all windows */
> > + for (i = 0; i < 6; i++) {
> > + mvreg_write(pp, MVNETA_WIN_BASE(i), 0);
> > + mvreg_write(pp, MVNETA_WIN_SIZE(i), 0);
> > +
> > + if (i < 4)
> > + mvreg_write(pp, MVNETA_WIN_REMAP(i), 0);
> > + }
> > +
> > + /*
> > + * Setup window #0 base 0x0 to target XBAR port 2 (AMB2), attribute 0xb, size 4GB
> > + * AMB2 address decoder remaps 0x0 to DDR 64 bit base address
> > + */
> > + mvreg_write(pp, MVNETA_WIN_BASE(0),
> > + (MVNETA_AC5_CNM_DDR_ATTR << 8) | MVNETA_AC5_CNM_DDR_TARGET);
> > + mvreg_write(pp, MVNETA_WIN_SIZE(0), 0xffff0000);
> > + mvreg_write(pp, MVNETA_BASE_ADDR_ENABLE, 0x3e);
> > +}
> > +
> > /* Power up the port */
> > static int mvneta_port_power_up(struct mvneta_port *pp, int phy_mode)
> > {
> > @@ -1508,11 +1544,15 @@ static int mvneta_recv(struct udevice *dev, int flags, uchar **packetp)
> > */
> > rx_desc = mvneta_rxq_next_desc_get(rxq);
> >
> > + if (!rx_desc)
> > + return 0;
> > +
> > rx_status = rx_desc->status;
> > if (!mvneta_rxq_desc_is_first_last(rx_status) ||
> > (rx_status & MVNETA_RXD_ERR_SUMMARY)) {
> > mvneta_rx_error(pp, rx_desc);
> > - /* leave the descriptor untouched */
> > + /* invalidate the descriptor */
> > + rx_desc->data_size = 0;
> > return -EIO;
> > }
> >
> > @@ -1525,13 +1565,15 @@ static int mvneta_recv(struct udevice *dev, int flags, uchar **packetp)
> > * No cache invalidation needed here, since the rx_buffer's are
> > * located in a uncached memory region
> > */
> > - *packetp = data;
> > + *packetp = data + pp->dma_base;
> >
> > /*
> > * Only mark one descriptor as free
> > * since only one was processed
> > */
> > mvneta_rxq_desc_num_update(pp, rxq, 1, 1);
> > + /* invalidate the descriptor */
> > + rx_desc->data_size = 0;
> > }
> >
> > return rx_bytes;
> > @@ -1544,6 +1586,11 @@ static int mvneta_probe(struct udevice *dev)
> > struct ofnode_phandle_args sfp_args;
> > #endif
> > void *bd_space;
> > + void *blob = (void *)gd->fdt_blob;
> > + int node = dev_of_offset(dev);
> > + const int *cell;
> > + int len;
> > +
> >
> > /*
> > * Allocate buffer area for descs and rx_buffers. This is only
> > @@ -1577,9 +1624,21 @@ static int mvneta_probe(struct udevice *dev)
> > /* Configure MBUS address windows */
> > if (device_is_compatible(dev, "marvell,armada-3700-neta"))
> > mvneta_bypass_mbus_windows(pp);
> > + else if (device_is_compatible(dev, "marvell,armada-ac5-neta"))
> > + mvneta_conf_ac5_cnm_xbar_windows(pp);
> > else
> > mvneta_conf_mbus_windows(pp);
> >
> > + /* fetch dma ranges property */
> > + cell = fdt_getprop(blob, node, "dma-ranges", &len);
> > + if (cell && len >= 4 * sizeof(int)) {
> > + /* RAZA - TODO do that in loop by address-cells size */
>
> Is this "TODO" something you wanted to address in the v2 patchset
> release?
>
That's from the original Marvell code. I've no idea who Raza is or if
(s)he ever got around to doing this. Pali has other concerns with this
part so I'll try to address removing the TODO along with avoiding open
coding the parsing.
> > + pp->dma_base = fdt32_to_cpu(cell[1]);
> > + pp->dma_base = (pp->dma_base << 32) | fdt32_to_cpu(cell[2]);
> > + } else {
> > + pp->dma_base = 0;
> > + }
> > +
> > #if CONFIG_IS_ENABLED(DM_GPIO)
> > if (!dev_read_phandle_with_args(dev, "sfp", NULL, 0, 0, &sfp_args) &&
> > ofnode_is_enabled(sfp_args.node))
> > @@ -1620,6 +1679,7 @@ static const struct eth_ops mvneta_ops = {
> >
> > static const struct udevice_id mvneta_ids[] = {
> > { .compatible = "marvell,armada-370-neta" },
> > + { .compatible = "marvell,armada-ac5-neta" },
> > { .compatible = "marvell,armada-xp-neta" },
> > { .compatible = "marvell,armada-3700-neta" },
> > { }
>
> Other than the above:
>
> Reviewed-by: Stefan Roese <sr at denx.de>
>
> Thanks,
> Stefan
More information about the U-Boot
mailing list