[PATCH 3/4] ARM: imx8m: verdin-imx8mm: Drop bogus content from spl_board_init()

Peng Fan peng.fan at oss.nxp.com
Wed Sep 21 07:31:30 CEST 2022



On 9/20/2022 3:41 AM, Marek Vasut wrote:
> The current implementation of spl_board_init() USB boot handling is
> not correct, the MX8MM BootROM v1 does not support SDP load when
> re-entered from U-Boot SPL, it is up to U-Boot to perform the next
> stage load using its own internal CI gadget driver and SDP protocol
> implementation. Drop the spl_board_init() to let SPL continue with
> normal load in case the SDP support is enabled.
> 

Reviewed-by: Peng Fan <peng.fan at nxp.com>

> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: Fabio Estevam <festevam at denx.de>
> Cc: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Cc: Max Krummenacher <max.krummenacher at toradex.com>
> Cc: Peng Fan <peng.fan at nxp.com>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
>   board/toradex/verdin-imx8mm/spl.c | 7 -------
>   1 file changed, 7 deletions(-)
> 
> diff --git a/board/toradex/verdin-imx8mm/spl.c b/board/toradex/verdin-imx8mm/spl.c
> index 59a3d9e0cae..210665bd6a9 100644
> --- a/board/toradex/verdin-imx8mm/spl.c
> +++ b/board/toradex/verdin-imx8mm/spl.c
> @@ -54,13 +54,6 @@ void spl_dram_init(void)
>   void spl_board_init(void)
>   {
>   	arch_misc_init();
> -
> -	/* Serial download mode */
> -	if (is_usb_boot()) {
> -		puts("Back to ROM, SDP\n");
> -		restore_boot_params();
> -	}
> -	puts("Normal Boot\n");
>   }
>   
>   #ifdef CONFIG_SPL_LOAD_FIT


More information about the U-Boot mailing list