[PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O Expander Controller

Fabio Estevam festevam at gmail.com
Tue Sep 27 14:15:51 CEST 2022


Hi Alice,

On Tue, Sep 6, 2022 at 6:37 AM Alice Guo (OSS) <alice.guo at oss.nxp.com> wrote:
>
> From: Alice Guo <alice.guo at nxp.com>

Please add a commit log.

> Signed-off-by: Alice Guo <alice.guo at nxp.com>

> --- a/arch/arm/include/asm/arch-imx9/gpio.h
> +++ b/arch/arm/include/asm/arch-imx9/gpio.h
> @@ -6,6 +6,8 @@
>  #ifndef __ASM_ARCH_IMX9_GPIO_H
>  #define __ASM_ARCH_IMX9_GPIO_H
>
> +#include <common.h>

This looks like an unrelated change.

> +config ADP5585_GPIO
> +       bool "ADP5585 GPIO driver"
> +       depends on DM_GPIO && DM_I2C
> +       help
> +         Support ADP5585 GPIO expander on i.MX platform.

Please remove "on i.MX platform" as the GPIO expander can be used on
any platform.


More information about the U-Boot mailing list