[PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O Expander Controller

[Alice Guo (OSS)]

> -----Original Message-----
> From: Fabio Estevam <festevam at gmail.com>
> Sent: Tuesday, September 27, 2022 8:16 PM
> To: Alice Guo (OSS) <alice.guo at oss.nxp.com>
> Cc: sbabic at denx.de; sjg at chromium.org; dl-uboot-imx <uboot-imx at nxp.com>;
> u-boot at lists.denx.de
> Subject: Re: [PATCH v1] gpio: adp5585: add gpio driver for ADP5585 I/O
> Expander Controller
> 
> Hi Alice,
> 
> On Tue, Sep 6, 2022 at 6:37 AM Alice Guo (OSS) <alice.guo at oss.nxp.com>
> wrote:
> >
> > From: Alice Guo <alice.guo at nxp.com>
> 
> Please add a commit log.
> 
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> 
> > --- a/arch/arm/include/asm/arch-imx9/gpio.h
> > +++ b/arch/arm/include/asm/arch-imx9/gpio.h
> > @@ -6,6 +6,8 @@
> >  #ifndef __ASM_ARCH_IMX9_GPIO_H
> >  #define __ASM_ARCH_IMX9_GPIO_H
> >
> > +#include <common.h>
> 
> This looks like an unrelated change.

Hi Fabio,

Thanks for your reply. When compiling without "#include <common.h>", the following error will appear:
In file included from ./arch/arm/include/asm/gpio.h:2,
                 from drivers/gpio/adp5585_gpio.c:10:
./arch/arm/include/asm/arch/gpio.h:12:9: error: unknown type name ‘u32’
   12 |         u32 gpio_pdor;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:13:9: error: unknown type name ‘u32’
   13 |         u32 gpio_psor;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:14:9: error: unknown type name ‘u32’
   14 |         u32 gpio_pcor;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:15:9: error: unknown type name ‘u32’
   15 |         u32 gpio_ptor;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:16:9: error: unknown type name ‘u32’
   16 |         u32 gpio_pdir;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:17:9: error: unknown type name ‘u32’
   17 |         u32 gpio_pddr;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:18:9: error: unknown type name ‘u32’
   18 |         u32 gpio_pidr;
      |         ^~~
./arch/arm/include/asm/arch/gpio.h:19:9: error: unknown type name ‘u8’
   19 |         u8 gpio_pxdr[32];


Best Regards,
Alice Guo

> > +config ADP5585_GPIO
> > +       bool "ADP5585 GPIO driver"
> > +       depends on DM_GPIO && DM_I2C
> > +       help
> > +         Support ADP5585 GPIO expander on i.MX platform.
> 
> Please remove "on i.MX platform" as the GPIO expander can be used on any
> platform.