[PATCH v6 4/4] board: toradex: add verdin am62 support

[Nishanth Menon]

On 12:08-20230804, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> 
> This adds initial support for the Toradex Verdin AM62 Quad 1GB WB IT
> V1.0A module and subsequent V1.1 launch configuration SKUs. They are
> strapped to boot from their on-module eMMC. U-Boot supports booting
> from the on-module eMMC only, DFU support is disabled for now due to
> missing AM62x USB support.
> 
> The device trees were taken straight from Linux v6.5-rc1.
> 
> Boot sequence is:
> SYSFW ---> R5 SPL (both in tiboot3.bin) ---> ATF (TF-A) ---> OP-TEE
>   ---> A53 SPL (part of tispl.bin) ---> U-boot proper (u-boot.img)
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> 
> ---

[...]

> diff --git a/doc/board/toradex/verdin-am62.rst b/doc/board/toradex/verdin-am62.rst
> new file mode 100644
> index 00000000000..ac0e86b3001
> --- /dev/null
> +++ b/doc/board/toradex/verdin-am62.rst
> @@ -0,0 +1,130 @@
> +.. SPDX-License-Identifier: GPL-2.0-or-later
> +.. sectionauthor:: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> +
> +Verdin AM62 Module
> +==================
> +
> +Quick Start
> +-----------

I'd leave a product link here:

Something like
`SoM <https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62>`_
 `Dev board <https://www.toradex.com/products/carrier-board/verdin-development-board-kit>`

 or something like that.

> +Output:
> +
> +.. code-block:: bash
> +
> +U-Boot SPL 2023.10-rc1-00210-gb678170a34c (Aug 03 2023 - 00:09:14 +0200)
> +SYSFW ABI: 3.1 (firmware rev 0x0009 '9.0.1--v09.00.01 (Kool Koala)')
> +SPL initial stack usage: 13368 bytes
> +Trying to boot from MMC1
> +Authentication passed
> +Authentication passed
> +Authentication passed
> +Authentication passed
> +Authentication passed
> +Starting ATF on ARM64 core...
> +
> +NOTICE:  BL31: v2.9(release):v2.9.0-73-g463655cc8
> +NOTICE:  BL31: Built : 14:51:42, Jun  5 2023
> +I/TC:
> +I/TC: OP-TEE version: 3.21.0-168-g322cf9e33 (gcc version 12.2.1 20221205 (Arm GNU Toolchain 12.2.Rel1 (Build arm-12.24))) #2 Mon Jun  5 13:04:15 UTC 2023 aarch64
> +I/TC: WARNING: This OP-TEE configuration might be insecure!
> +I/TC: WARNING: Please check https://optee.readthedocs.io/en/latest/architecture/porting_guidelines.html
> +I/TC: Primary CPU initializing
> +I/TC: SYSFW ABI: 3.1 (firmware rev 0x0009 '9.0.1--v09.00.01 (Kool Koala)')
> +I/TC: HUK Initialized
> +I/TC: Primary CPU switching to normal world boot
> +
> +U-Boot SPL 2023.10-rc1-00210-gb678170a34c (Aug 03 2023 - 00:09:41 +0200)
> +SYSFW ABI: 3.1 (firmware rev 0x0009 '9.0.1--v09.00.01 (Kool Koala)')
> +SPL initial stack usage: 1840 bytes
> +Trying to boot from MMC1
> +Authentication passed
> +Authentication passed
> +
> +
> +U-Boot 2023.10-rc1-00210-gb678170a34c (Aug 03 2023 - 00:09:41 +0200)
> +
> +SoC:   AM62X SR1.0 HS-FS
> +DRAM:  2 GiB
> +Core:  136 devices, 28 uclasses, devicetree: separate
> +MMC:   mmc at fa10000: 0, mmc at fa00000: 1
> +Loading Environment from MMC... OK
> +In:    serial at 2800000
> +Out:   serial at 2800000
> +Err:   serial at 2800000
> +Model: Toradex 0076 Verdin AM62 Quad 2GB WB IT V1.0A
> +Serial#: 15037380
> +Carrier: Toradex Verdin Development Board V1.1A, Serial# 10754333
> +am65_cpsw_nuss ethernet at 8000000: K3 CPSW: nuss_ver: 0x6BA01103 cpsw_ver: 0x6BA81103 ale_ver: 0x00290105 Ports:2 mdio_freq:1000000
> +Setting variant to wifi
> +Net:
> +Warning: ethernet at 8000000port@1 MAC addresses don't match:
> +Address in ROM is		1c:63:49:22:5f:f9
> +Address in environment is	00:14:2d:e5:73:c4
> +eth0: ethernet at 8000000port@1 [PRIME], eth1: ethernet at 8000000port@2
> +Hit any key to stop autoboot:  0
> +Verdin AM62 #

I think you missed adding white space here.

It renders as this: https://usercontent.irccloud-cdn.com/file/625Dsdcq/image.png

With that fixed, please feel free to add:

Reviewed-by: Nishanth Menon <nm at ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D