[PATCH v6 4/4] board: toradex: add verdin am62 support

[Tom Rini]

On Fri, Aug 04, 2023 at 01:20:03PM -0500, Nishanth Menon wrote:
> On 12:08-20230804, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > This adds initial support for the Toradex Verdin AM62 Quad 1GB WB IT
> > V1.0A module and subsequent V1.1 launch configuration SKUs. They are
> > strapped to boot from their on-module eMMC. U-Boot supports booting
> > from the on-module eMMC only, DFU support is disabled for now due to
> > missing AM62x USB support.
> > 
> > The device trees were taken straight from Linux v6.5-rc1.
> > 
> > Boot sequence is:
> > SYSFW ---> R5 SPL (both in tiboot3.bin) ---> ATF (TF-A) ---> OP-TEE
> >   ---> A53 SPL (part of tispl.bin) ---> U-boot proper (u-boot.img)
> > 
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > 
> > ---
> 
> [...]
> 
> > diff --git a/doc/board/toradex/verdin-am62.rst b/doc/board/toradex/verdin-am62.rst
> > new file mode 100644
> > index 00000000000..ac0e86b3001
> > --- /dev/null
> > +++ b/doc/board/toradex/verdin-am62.rst
> > @@ -0,0 +1,130 @@
> > +.. SPDX-License-Identifier: GPL-2.0-or-later
> > +.. sectionauthor:: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> > +
> > +Verdin AM62 Module
> > +==================
> > +
> > +Quick Start
> > +-----------
> 
> I'd leave a product link here:
> 
> Something like
> `SoM <https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62>`_
>  `Dev board <https://www.toradex.com/products/carrier-board/verdin-development-board-kit>`
> 
>  or something like that.
> 
> > +Output:
> > +
> > +.. code-block:: bash
[snip]
> I think you missed adding white space here.
> 
> It renders as this: https://usercontent.irccloud-cdn.com/file/625Dsdcq/image.png

This is how all of the verdin boot logs render, and are all wrong.  It
should instead be:

Output::

  U-Boot SPL 2023.10-rc1-00210-gb678170a34c (Aug 03 2023 - 00:09:14 +0200)
  ...

And I think we can take both of these as a follow-up patch that Heinrich
will take and pass along before v2023.10 is out.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230804/d6d77029/attachment.sig>