[PATCH 6/6] stm32mp15: Use u-boot-spl-stm32.bin instead of u-boot-spl.stm32

[Patrick DELAUNAY]

Hi Simon,

On 8/24/23 17:14, Tom Rini wrote:
> On Thu, Aug 24, 2023 at 05:09:07PM +0200, Marek Vasut wrote:
>> On 8/24/23 16:25, Tom Rini wrote:
>>> On Thu, Aug 24, 2023 at 05:12:45AM +0200, Marek Vasut wrote:
>>>> On 8/24/23 05:02, Simon Glass wrote:
>>>>> A '.stm32' extension is not allowed anymore, so change it.
>>>> Why?
>>>>
>>>> This will likely break a huge amount of scripts, I'm tempted to NAK it
>>>> unless there is a very good reason.
>>> This is in the cover letter.  Today, buildman --keep-outputs doesn't
>>> actually keep the needed for booting outputs from a build for a number
>>> of platforms.  Simon's response is to stop having a free-form list of
>>> outputs. With I guess the caveat being ROM-defined names (for example,
>>> we still keep "MLO" because that is the literal filename TI ROM looks
>>> for on FAT partitions, on mos of their 32bit platforms).
>> Why not just place the free-form files into some output/ directory and be
>> done with it ? Then they can have whatever extension they want, as long as
>> the output/ directory name is stable.
> Yes, an alternative here is to just extend the list that's removed in
> patch 2/6.
>

The ".stm32" was choosen on output on mkimage to be aligned with:

- all STMicroelectonics documentation  (for example 
https://wiki.st.com/stm32mpu/wiki/STM32_header_for_binary_files)

- the proposed scripts or files, in particular in the YOCTO generated 
flashlayout files.

- this extension list expected by our tools: STM CubeProgrammer 
(https://wiki.st.com/stm32mpu/wiki/STM32CubeProgrammer)

and Signing tools (https://wiki.st.com/stm32mpu/wiki/Signing_tool)


So I prefer to kept the ".stm32" extension here:

	filename = "u-boot-spl.stm32"


NB: the justification for buildman '-k' option seens not fully relevant here

        because in patch 2/6 you kept not only the ALLOWED extension but 
also some particular files

+                to_copy = ['u-boot*', '*.map', 'MLO', 'SPL',
+                           'include/autoconf.mk', 'spl/u-boot-spl*']
+                to_copy += [f'*{ext}' for ext in ALLOWED_EXTS]


so all the files "u-boot*" are kept with buildman -k even if it is not a 
allowed extension.


I propose to change the patch 1/6 if you are agree

and allow binman to generate the file with same rules than buildman -k 
option in patch 2/6


The filename is valid if

- the file is named with the allowed prefix 'u-boot' => 'u-boot*' so 
"u-boot-spl.stm32" is allowed

- the file is with allowed extension =>.bin, .rom, .itb, .img


Regards


Patrick