[PATCH] net: wget: Support non-default HTTP port

Tom Rini trini at konsulko.com
Wed Dec 13 15:55:46 CET 2023


On Sat, Nov 04, 2023 at 04:09:54PM +0100, Marek Vasut wrote:

> Currently the wget command is hard wired to HTTP port 80. This is
> inconvenient, as it is extremely easy to start trivial HTTP server
> as an unprivileged user using e.g. python http module to serve the
> files, but such a server has to run on one of the higher ports:
> "
> $ python3 -m http.server -d $(pwd) 8080
> "
> 
> Make it possible to configure HTTP server port the same way it is
> possible to configure TFTP server port, using environment variable
> 'httpdstp' (similar to 'tftpdstp'). Retain port 80 as the default
> fallback port. This way, users can start their own trivial server
> and conveniently download whatever files they need into U-Boot.
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: "Ying-Chun Liu (PaulLiu)" <paul.liu at linaro.org>
> Cc: Duncan Hare <DuncanCHare at yahoo.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Marek Vasut <marex at denx.de>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> ---
>  include/net/wget.h |  1 -
>  net/wget.c         | 14 ++++++++++----
>  2 files changed, 10 insertions(+), 5 deletions(-)

Sorry for the late review, can you please update the docs as well with
this? For example 'tftpdstp' is documented in both the environment doc
and the tftp command doc.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231213/13e7fd3e/attachment.sig>


More information about the U-Boot mailing list