[PATCH V5 09/12] arm: dts: iot2050: Optionally embed OTP programming data into image

[Jan Kiszka]

On 03.02.23 13:37, Lothar Waßmann wrote:
> Hi,
> 
> On Fri,  3 Feb 2023 13:26:38 +0100 Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka at siemens.com>
>>
>> Use external blob otpcmd.bin to replace the 0xff filled OTP programming
>> command block to create a firmware image that provisions the OTP on
>> first boot. This otpcmd.bin is generated from the customer keys using
>> steps described in the meta-iot2050 integration layer for the device.
>>
>> Based on original patch by Baocheng Su.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
>> ---
>>  arch/arm/dts/k3-am65-iot2050-boot-image.dtsi | 8 ++++++++
>>  board/siemens/iot2050/Kconfig                | 7 +++++++
>>  doc/board/siemens/iot2050.rst                | 8 ++++++++
>>  tools/binman/missing-blob-help               | 8 ++++++++
>>  4 files changed, 31 insertions(+)
>>
>> diff --git a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
>> index 9082a79a034..25a22a7b7b8 100644
>> --- a/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
>> +++ b/arch/arm/dts/k3-am65-iot2050-boot-image.dtsi
>> @@ -111,10 +111,18 @@
>>  		};
>>  
>>  		/* OTP update command block */
>> +#if CONFIG_IOT2050_EMBED_OTPCMD
>> +		blob-ext at 0x6c0000 {
>> +			offset = <0x6c0000>;
>> +			size   = <0x010000>;
>> +			filename = "otpcmd.bin";
>> +			missing-msg = "iot2050-otpcmd";
>> +#else
>>  		fill at 0x6c0000 {
>>  			offset = <0x6c0000>;
>>  			size   = <0x010000>;
>>  			fill-byte = [ff];
>> +#endif
>>  		};
>>
> I would rather include the closing brace in the #if #else block...
> Otherwise people who might copy part of the code will have a bad
> experience.
> 

Yeah, will address if there is a need for v6, otherwise later on top.

Thanks,
Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux