[PATCH V5 08/12] iot2050: Add script for signing artifacts

[Jan Kiszka]

On 06.02.23 11:47, Jan Kiszka wrote:
> On 04.02.23 23:26, Simon Glass wrote:
>> Hi Jan,
>>
>> On Fri, 3 Feb 2023 at 23:35, Jan Kiszka <jan.kiszka at siemens.com> wrote:
>>>
>>> On 03.02.23 19:51, Tom Rini wrote:
>>>> On Fri, Feb 03, 2023 at 01:26:37PM +0100, Jan Kiszka wrote:
>>>>
>>>>> From: Jan Kiszka <jan.kiszka at siemens.com>
>>>>>
>>>>> There are many ways to get a signed firmware for the IOT2050 devices,
>>>>> namely for the parts under user-control. This script documents one way
>>>>> of doing it, given a signing key. Augment the board documentation with
>>>>> the required procedure around it.
>>>>>
>>>>> Signed-off-by: Jan Kiszka <jan.kiszka at siemens.com>
>>>> [snip]
>>>>> +# currently broken in upstream
>>>>> +#source/tools/binman/binman replace -i flash.bin -f fit at 0x380000.fit fit at 0x380000
>>>>> +dd if=fit at 0x380000.fit of=flash.bin bs=$((0x1000)) seek=$((0x380000/0x1000)) conv=notrunc
>>>>
>>>> Is that still a true comment?
>>>>
>>>
>>> binman: Node '/fit at 0x380000/images/u-boot': Offset 0x0 (0) size 0xb8870
>>> (755824) is outside the section '/fit at 0x380000' starting at 0x0 (0) of
>>> size 0x400 (1024)
>>>
>>> And for the second call:
>>>
>>> binman: Node '/fit at 0x380000': Replacing sections is not implemented yet
>>
>> I sent a patch to implement that.
>>
>> I'm not quite sure if this resolves the first problem, too. If not,
>> can you please provide a binman test for the case you need, or
>> instructions on how to cause the failure?
> 
> Instructions to reproduce are basically
>  - apply this series
>  - build flash.bin according to doc/board/siemens/iot2050.rst
>  - drop the dd calls and activate binman in this signing script
>  - run it
> 
> But I'll try your patch ASAP on my setup.

Still left with

binman: Node '/fit at 0x380000/images/u-boot': Offset 0x0 (0) size 0xb8928
(756008) is outside the section '/fit at 0x380000' starting at 0x0 (0) of
size 0x400 (1024)

and

binman: 'NoneType' object has no attribute 'props'

That was for the second call of binman (source/tools/binman/binman
replace -i flash.bin -f fit at 0x380000.fit fit at 0x380000). The "not
implemented messages is gone.

I've switched back to dd for the first call, but that did not work yet.
So the message above indicates a relevant error.

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux