[PATCH 2/7] dlmalloc: Fix a warning with clang-15

Tom Rini trini at konsulko.com
Tue Feb 28 02:38:00 CET 2023


On Mon, Feb 27, 2023 at 05:35:30PM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 27 Feb 2023 at 15:08, Tom Rini <trini at konsulko.com> wrote:
> >
> > With clang-15 we now will get warnings such as:
> >
> > warning: a function declaration without a prototype is deprecated in all
> > versions of C [-Wstrict-prototypes]
> >
> > And it is easy enough to address this warning here, as we aren't
> > concerned with re-syncing with an upstream.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  common/dlmalloc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> >
> > diff --git a/common/dlmalloc.c b/common/dlmalloc.c
> > index 41c7230424cc..0f9b7262d512 100644
> > --- a/common/dlmalloc.c
> > +++ b/common/dlmalloc.c
> > @@ -80,7 +80,7 @@ GmListElement* makeGmListElement (void* bas)
> >         return this;
> >  }
> >
> > -void gcleanup ()
> > +void gcleanup (void)
> 
> drop space before ( ?

The file is so badly out of sync with our coding style I literally just
went and did %s/()$/(void)/ to move on to the next sets of problems. So
I'd rather not fix one more style issue here when I suspect there's a
barely exaggerated thousand more.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230227/566fba8b/attachment.sig>


More information about the U-Boot mailing list