[PATCHv2 3/4] fwu: gpt: implement read_mdata and write_mdata callbacks

[Jassi Brar]

On Mon, 2 Jan 2023 at 03:48, Etienne Carriere
<etienne.carriere at linaro.org> wrote:
>
> Hi Jassi,
>
> On Thu, 22 Dec 2022 at 13:59, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > Hi Jassi,
> >
> > On Fri, Dec 02, 2022 at 09:17:12PM -0600, jassisinghbrar at gmail.com wrote:
> > > From: Jassi Brar <jaswinder.singh at linaro.org>
> > >
> > > Moving towards using common code for meta-data management,
> > > implement the read/write mdata hooks.
> > >
> > > Signed-off-by: Jassi Brar <jaswinder.singh at linaro.org>
> > > ---
> > >  drivers/fwu-mdata/gpt_blk.c | 40 +++++++++++++++++++++++++++++++++++--
> > >  1 file changed, 38 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c
> > > index 28f5d23e1e..35239c0a4f 100644
> > > --- a/drivers/fwu-mdata/gpt_blk.c
> > > +++ b/drivers/fwu-mdata/gpt_blk.c
> > > @@ -222,7 +222,7 @@ static int fwu_gpt_read_mdata_partition(struct udevice *dev,
> > >       struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev);
> > >
> > >       return gpt_read_write_mdata(dev_get_uclass_plat(priv->blk_dev),
> > > -                                 mdata, MDATA_READ, part_num);
> > > +                                mdata, MDATA_READ, part_num);
> >
> > I assume this was by mistake?
> >
During the churn I changed from indentation by tabs to spaces. I will
drop the change.

> >
> > Other than that
> > Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> >
>
> Reviewed-by: Etienne Carriere <etienne.carriere at linaro.org> with
> Ilias' comments addressed.

Thanks.