[PATCH] tpm2: ftpm: add the device in the OP-TEE services list

[Etienne Carriere]

On Thu, 19 Jan 2023 at 16:11, Jens Wiklander <jens.wiklander at linaro.org> wrote:
>
> On Thu, Jan 19, 2023 at 3:36 PM Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > commit fe8a4ed0111073 ("tee: optee: discover services dependent on tee-supplicant")
> > is trying to automatically scan and add TAs that are presented on pseudo
> > bus from the secure world.
> > In orer to be able to list and compare the scanned devices the available drivers
> In order to...
>
> > have to register themselves on the op-tee service list.
> >
> > Signed-off-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> > ---
> >  drivers/tpm/tpm2_ftpm_tee.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/tpm/tpm2_ftpm_tee.c b/drivers/tpm/tpm2_ftpm_tee.c
> > index 3c4c12983daa..f0deaec5b076 100644
> > --- a/drivers/tpm/tpm2_ftpm_tee.c
> > +++ b/drivers/tpm/tpm2_ftpm_tee.c
> > @@ -18,10 +18,12 @@
> >  #include <log.h>
> >  #include <tpm-v2.h>
> >  #include <tee.h>
> > +#include <tee/optee_service.h>
> >
> >  #include "tpm_tis.h"
> >  #include "tpm2_ftpm_tee.h"
> >
> > +OPTEE_SERVICE_DRIVER(optee_ftpm, TA_FTPM_UUID, "ftpm_tee");
> >  /**

Add an empty line between the 2 above lines.
With that fixed and Jens' comment addressed,
Acked-by: Etienne Carriere <etienne.carriere at linaro.org>

> >   * ftpm_tee_transceive() - send fTPM commands and retrieve fTPM response.
> >   * @sendbuf - address of the data to send, byte by byte
> > --
> > 2.38.1
> >
>
> With the spelling error in the commit message fixed.
>
> Reviewed-by: Jens Wiklander <jens.wiklander at linaro.org>
>
> Cheers,
> Jens