[PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode driver

[Simon Glass]

Hi Ryan,

On Fri, 20 Jan 2023 at 17:10, Ryan Chen <ryan_chen at aspeedtech.com> wrote:
>
> > -----Original Message-----
> > From: Simon Glass <sjg at chromium.org>
> > Sent: Saturday, January 21, 2023 5:58 AM
> > To: Ryan Chen <ryan_chen at aspeedtech.com>
> > Cc: Heiko Schocher <hs at denx.de>; BMC-SW <BMC-SW at aspeedtech.com>;
> > u-boot at lists.denx.de
> > Subject: Re: [PATCH v2 1/1] i2c:aspeed:support ast2600 i2c new register mode
> > driver
> >
> > Hi Ryan,
> >
> > On Thu, 19 Jan 2023 at 20:12, Ryan Chen <ryan_chen at aspeedtech.com>
> > wrote:
> > >
> > > Hello Simon,
> > >         Sorry, do you have time to check v2 patch?
> >
> > I did not see a change log on it, so was not sure anything was needed?
> > Were there changes from the previous version?
>
> There have cover latter [PATCH v2 0/1]
> https://www.mail-archive.com/u-boot@lists.denx.de/msg460560.html

You can use patman to produce a change list on each patch, then
collate the change lists into the cover letter. That way it is easier
to put it on the patch, which is where I would expect it, while still
having the cover letter show all changes.

It looks OK to me..but re this one:

ret = uclass_get_device_by_driver(UCLASS_MISC,
+                                         DM_DRIVER_GET(aspeed_i2c_global),
+                                         &global_dev);

Can you not use the parent device?

Regards,
Simon