[PATCH 1/2] DO NOT MERGE: mmc: dw_mmc: Keep vqmmc-supply enable count in balance

Jonas Karlman jonas at kwiboo.se
Sun Jul 2 14:41:14 CEST 2023


With the series "regulator: implement basic reference counter" [1],
keeping regulator enablement in balance become more important.

Disable vqmmc-supply before signal voltage is changed to keep regulator
enable counter in balance.

[1] https://patchwork.ozlabs.org/project/uboot/list/?series=351536

Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
---
 drivers/mmc/dw_mmc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c
index 5085a3b491da..400066fa99a2 100644
--- a/drivers/mmc/dw_mmc.c
+++ b/drivers/mmc/dw_mmc.c
@@ -509,6 +509,10 @@ static int dwmci_set_ios(struct mmc *mmc)
 	if (mmc->vqmmc_supply) {
 		int ret;
 
+		ret = regulator_set_enable_if_allowed(mmc->vqmmc_supply, false);
+		if (ret)
+			return ret;
+
 		if (mmc->signal_voltage == MMC_SIGNAL_VOLTAGE_180)
 			regulator_set_value(mmc->vqmmc_supply, 1800000);
 		else
-- 
2.41.0



More information about the U-Boot mailing list