[PATCH v2] ARM: imx: romapi: Fix signed integer bitwise ops misuse

Heiko Schocher hs at denx.de
Mon Jul 3 07:42:39 CEST 2023


Hello Marek,

On 02.07.23 03:03, Marek Vasut wrote:
> Bitwise operations on signed integers are not defined,
> replace them with per-call checks.
> 
> Reviewed-by: Peng Fan <peng.fan at nxp.com>
> Signed-off-by: Marek Vasut <marex at denx.de>
> ---
> Cc: "NXP i.MX U-Boot Team" <uboot-imx at nxp.com>
> Cc: Fabio Estevam <festevam at denx.de>
> Cc: Heiko Schocher <hs at denx.de>
> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Cc: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Ye Li <ye.li at nxp.com>
> ---
> V2: - s at then@them@
>     - Add RB from Peng
> ---
>  arch/arm/mach-imx/spl_imx_romapi.c | 32 ++++++++++++++++++++----------
>  1 file changed, 21 insertions(+), 11 deletions(-)

good catch!

Reviewed-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list