[PATCH v2 24/60] buildman: Tweak commits and show_bloat
Simon Glass
sjg at chromium.org
Wed Jul 5 14:18:52 CEST 2023
Move setting of show_bloat to adjust_options() and adjust how the commits
variable is set. Together these remove the pylint warning about too many
statements.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
(no changes since v1)
tools/buildman/control.py | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 83ce8141eae4..4f493006474e 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -433,6 +433,10 @@ def adjust_options(options, series, selected):
if not options.step:
options.step = len(series.commits) - 1
+ # We can't show function sizes without board details at present
+ if options.show_bloat:
+ options.show_detail = True
+
def setup_output_dir(output_dir, work_in_output, branch, no_subdirs, col,
clean_dir):
@@ -572,18 +576,11 @@ def do_buildman(options, args, toolchains=None, make_func=None, brds=None,
# Work out which boards to build
board_selected = brds.get_selected_dict()
- if series:
- commits = series.commits
- else:
- commits = None
-
+ commits = series.commits if series else None
if not options.ide:
tprint(get_action_summary(options.summary, commits, board_selected,
options.step, options.threads, options.jobs))
- # We can't show function sizes without board details at present
- if options.show_bloat:
- options.show_detail = True
builder.SetDisplayOptions(
options.show_errors, options.show_sizes, options.show_detail,
options.show_bloat, options.list_error_boards, options.show_config,
--
2.41.0.255.g8b1d071c50-goog
More information about the U-Boot
mailing list