[PATCH v2 30/60] buildman: Use get_alow_missing() directly to avoid var

Simon Glass sjg at chromium.org
Wed Jul 5 14:18:58 CEST 2023


Avoid an unnecessary local variable by moving this code to a function.
This fixes the pylint warning about too many local variables.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

(no changes since v1)

 tools/buildman/control.py | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 873b5aadfca8..c2ac56e43cc9 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -594,10 +594,6 @@ def do_buildman(options, args, toolchains=None, make_func=None, brds=None,
                      options.verbose)
         return 0
 
-    allow_missing = get_allow_missing(options.allow_missing,
-                                      options.no_allow_missing, len(selected),
-                                      options.branch)
-
     # Create a new builder with the selected options
     builder = Builder(toolchains, output_dir, git_dir,
             options.threads, options.jobs, checkout=True,
@@ -613,7 +609,10 @@ def do_buildman(options, args, toolchains=None, make_func=None, brds=None,
             test_thread_exceptions=test_thread_exceptions,
             adjust_cfg=calc_adjust_cfg(options.adjust_cfg,
                                        options.reproducible_builds),
-            allow_missing=allow_missing, no_lto=options.no_lto,
+            allow_missing=get_allow_missing(options.allow_missing,
+                                            options.no_allow_missing,
+                                            len(selected), options.branch),
+            no_lto=options.no_lto,
             reproducible_builds=options.reproducible_builds,
             force_build = options.force_build,
             force_build_failures = options.force_build_failures,
-- 
2.41.0.255.g8b1d071c50-goog



More information about the U-Boot mailing list