[PATCH v3 u-boot] mmc: spl: Make partition choice in default_spl_mmc_emmc_boot_partition() more explicit

Pali Rohár pali at kernel.org
Sat Jul 8 10:30:47 CEST 2023


On Friday 07 July 2023 19:43:34 Tom Rini wrote:
> On Sat, Jul 08, 2023 at 12:54:38AM +0200, Pali Rohár wrote:
> 
> > To make eMMC partition choosing in default_spl_mmc_emmc_boot_partition()
> > function better understandable, rewrite it via explicit switch-case code
> > pattern.
> > 
> > Also indicate an error when eMMC EXT_CSD[179] register is configured by
> > user to value which is not suitable for eMMC booting and SPL do not know
> > how to interpret it.
> > 
> > Signed-off-by: Pali Rohár <pali at kernel.org>
> 
> I did some quick local testing to check on the size impact and this is
> indeed quite manageable, thanks for reworking things!
> 
> Reviewed-by: Tom Rini <trini at konsulko.com>
> 
> -- 
> Tom

Unfortunately no, sama5d2_xplained_emmc, sama5d2_xplained_mmc and
sama5d2_xplained_qspiflash are failing with v3; but not with v2.

Seems that these boards have their SPL at limit and adding any new
puts() increase size over the limit.

So I think that there is no other way than just adding a new config
option to hide this new puts().


More information about the U-Boot mailing list