[PATCH] efi_loader: Avoid underflow when calculating remaining var store size

Alper Nebi Yasak alpernebiyasak at gmail.com
Sat Jul 8 17:23:05 CEST 2023

The efi_var_mem_free() function calculates the available size for a new
EFI variable by subtracting the occupied buffer size and the overhead
for a new variable from the maximum buffer size set in Kconfig. This
is then returned as QueryVariableInfo()'s RemainingVariableStorageSize

This can underflow as the calculation is done in and processed as
unsigned integer types. Check for underflow before doing the subtraction
and return zero if there's no space.

Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>

 lib/efi_loader/efi_var_mem.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/efi_loader/efi_var_mem.c b/lib/efi_loader/efi_var_mem.c
index d6b65aed12ea..5fa7dcb8d3ed 100644
--- a/lib/efi_loader/efi_var_mem.c
+++ b/lib/efi_loader/efi_var_mem.c
@@ -177,6 +177,10 @@ efi_status_t __efi_runtime efi_var_mem_ins(
 u64 __efi_runtime efi_var_mem_free(void)
+	if (efi_var_buf->length + sizeof(struct efi_var_entry) >=
+		return 0;
 	return EFI_VAR_BUF_SIZE - efi_var_buf->length -
 	       sizeof(struct efi_var_entry);

More information about the U-Boot mailing list