[PATCH v2 00/11] Remove unnecessary USBx dr_mode configuration.

Julien Panis jpanis at baylibre.com
Mon Jul 10 15:54:08 CEST 2023


For all TI platforms handled in this series, USBx dr_mode
was configured as peripheral in '<board>-u-boot.dtsi'.
This series removes these fragments, since USBx dual-role
feature is already handled as peripheral only in
'dwc3_glue_bind_common()' function of 'dwc3-generic.c' driver:

static int dwc3_glue_bind_common(struct udevice *parent, ofnode node)
{
	[...]

	switch (dr_mode) {
	case USB_DR_MODE_PERIPHERAL:
	case USB_DR_MODE_OTG:

		debug("%s: dr_mode: OTG or Peripheral\n", __func__);
		driver = "dwc3-generic-peripheral";

		break;

	[...]
}

This follows a discussion about a similar topic for am3 boards:
https://lore.kernel.org/u-boot/20230621-fix_usb_ether_init-v4-0-5f4977bb7678@baylibre.com/

Signed-off-by: Julien Panis <jpanis at baylibre.com>
---
Changes in v2:
- Handle 'unknown' mode as 'otg' in dwc3 usb driver.
- Link to v1: https://lore.kernel.org/r/20230706-handle-otg-as-periph-v1-0-bd85d15ffd50@baylibre.com

---
Julien Panis (11):
      usb: dwc3: Handle unknown mode as otg
      arm: dts: dra7-evm-u-boot: Remove usb1 mode configuration
      arm: dts: dra71-evm-u-boot: Remove usb1 mode configuration
      arm: dts: dra72-evm-revc-u-boot: Remove usb1 mode configuration
      arm: dts: dra72-evm-u-boot: Remove usb1 mode configuration
      arm: dts: dra76-evm-u-boot: Remove usb1 mode configuration
      arm: dts: k3-am642-evm-u-boot: Remove usb0 mode configuration
      arm: dts: k3-am654-r5-base-board-u-boot: Remove usb mode configuration
      arm: dts: k3-j7200-common-proc-board-u-boot: Remove usb0 mode configuration
      arm: dts: k3-j721e-common-proc-board-u-boot: Remove usb0 mode configuration
      arm: dts: keystone-k2e-evm-u-boot: Remove usb1 mode configuration

 arch/arm/dts/dra7-evm-u-boot.dtsi                   | 1 -
 arch/arm/dts/dra71-evm-u-boot.dtsi                  | 1 -
 arch/arm/dts/dra72-evm-revc-u-boot.dtsi             | 1 -
 arch/arm/dts/dra72-evm-u-boot.dtsi                  | 1 -
 arch/arm/dts/dra76-evm-u-boot.dtsi                  | 1 -
 arch/arm/dts/k3-am642-evm-u-boot.dtsi               | 1 -
 arch/arm/dts/k3-am654-r5-base-board-u-boot.dtsi     | 5 -----
 arch/arm/dts/k3-j7200-common-proc-board-u-boot.dtsi | 1 -
 arch/arm/dts/k3-j721e-common-proc-board-u-boot.dtsi | 1 -
 arch/arm/dts/keystone-k2e-evm-u-boot.dtsi           | 1 -
 drivers/usb/dwc3/dwc3-generic.c                     | 4 ++--
 11 files changed, 2 insertions(+), 16 deletions(-)
---
base-commit: 19b77d3d23966a0d6dbb3c86187765f11100fb6f
change-id: 20230706-handle-otg-as-periph-4546e874cd15

Best regards,
-- 
Julien Panis <jpanis at baylibre.com>



More information about the U-Boot mailing list