[PATCH 10/10] arm: dts: keystone-k2e-evm-u-boot: Remove usb1 mode configuration

Tom Rini trini at konsulko.com
Mon Jul 10 17:21:15 CEST 2023


On Mon, Jul 10, 2023 at 10:57:19AM +0200, Julien Panis wrote:
> Hi Roger,
> 
> On 7/10/23 09:53, Roger Quadros wrote:
> > Hi Julien,
> > 
> > On 06/07/2023 19:07, Julien Panis wrote:
> > > USB1 dual-role feature is already handled as peripheral only
> > > in dwc3-generic driver.
> > > 
> > > Signed-off-by: Julien Panis <jpanis at baylibre.com>
> > > ---
> > >   arch/arm/dts/keystone-k2e-evm-u-boot.dtsi | 1 -
> > >   1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/arch/arm/dts/keystone-k2e-evm-u-boot.dtsi b/arch/arm/dts/keystone-k2e-evm-u-boot.dtsi
> > > index 970d452f0804..a75f78377c28 100644
> > > --- a/arch/arm/dts/keystone-k2e-evm-u-boot.dtsi
> > > +++ b/arch/arm/dts/keystone-k2e-evm-u-boot.dtsi
> > > @@ -39,7 +39,6 @@
> > >   &usb1 {
> > >   	dwc3 at 25010000 {
> > >   		phys = <&usb1_phy>;
> > > -		dr_mode = "peripheral";
> > >   		snps,u2ss_inp3_quirk;
> > >   		status = "okay";
> > >   	};
> > > 
> > keystone-k2e.dtsi nor keystone-k2e-evm.dtsi has dr_mode set anywhere.
> > In Linux, keystone-k2e-evm.dtsi has dr_mode as "peripheral".
> > Can we please have the same in u-boot as well?
> 
> I can do that, but...
> ...shouldn't uboot dts have been sync'ed with linux dts before ?

*cough* Keystone 2 is unmaintained in U-Boot currently and Nishanth owes
me a patch taking over the machines.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230710/579bea12/attachment.sig>


More information about the U-Boot mailing list