[PATCH 1/2] cmd: thordown: Add proper dependency for CMD_THOR_DOWNLOAD

[Tom Rini]

On Sun, Jul 09, 2023 at 07:09:57AM -0600, Ashok Reddy Soma wrote:
> When CONFIG_CMD_USB and CONFIG_USB are disabled some compilation errors
> are seen as below.
> 
> cmd/thordown.o: in function `usb_gadget_initialize':
> include/linux/usb/gadget.h:981: undefined reference to `board_usb_init'
> cmd/thordown.o: in function `do_thor_down':
> cmd/thordown.c:68: undefined reference to `g_dnl_unregister'
> cmd/thordown.o: in function `usb_gadget_release':
> include/linux/usb/gadget.h:986: undefined reference to `board_usb_cleanup'
> cmd/thordown.o: in function `do_thor_down':
> cmd/thordown.c:41: undefined reference to `g_dnl_register'
> cmd/thordown.c:48: undefined reference to `thor_init'
> cmd/thordown.c:56: undefined reference to `thor_handle'
> gnu/aarch64/lin/aarch64-linux/bin/aarch64-linux-gnu-ld.bfd: line 4:  8485
> Segmentation fault      (core dumped) $CC --sysroot=$LIBC
> --no-warn-rwx-segment "$@"
> Makefile:1779: recipe for target 'u-boot' failed
> make: *** [u-boot] Error 139
> make: *** Deleting file 'u-boot'
> 
> Add dependency of CMD_USB for CONFIG_CMD_THOR_DOWNLOAD to fix the errors.
> 
> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> ---
> 
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 02e54f1e50..b44df9d67a 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -526,6 +526,7 @@ config CMD_SPL_WRITE_SIZE
>  
>  config CMD_THOR_DOWNLOAD
>  	bool "thor - TIZEN 'thor' download"
> +	depends on CMD_USB
>  	select DFU
>  	help
>  	  Implements the 'thor' download protocol. This is a way of

This isn't right, and removes the command from s5p_goni. The issue is
that CMD_USB is for host support, and this is a gadget command. Likely
the best answer is to make this depend on USB_FUNCTION_THOR, or select
USB_FUNCTION_THOR but depend on USB_GADGET_DOWNLOAD.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230714/8dc23412/attachment.sig>