[PATCH] ufs: Use 'TASK_TAG' to construct the ucd_req_ptr->header.dword_0

Tom Rini trini at konsulko.com
Sat Jul 15 17:03:41 CEST 2023


On Mon, Jul 03, 2023 at 12:39:12AM +0530, Bhupesh Sharma wrote:
> Instead of using the hard-coded value of 0x1f, use 'TASK_TAG'
> macro instead to construct the ucd_req_ptr->header.dword_0
> 
> This is in sync with what the Linux UFS driver does, i.e.
> set the byte0 equal to TASK_TAG (see [1]).
> 
> Setting it to a fixed value of 0x1f is wrong as we define
> TASK_TAG as 0 inside u-boot ufs framework. So, instead we
> should  use the macro value directly.
> 
> [1]. https://github.com/torvalds/linux/blob/master/drivers/ufs/core/ufshcd.c#L2705
> 

> Signed-off-by: Bhupesh Sharma <bhupesh.sharma at linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230715/ab440716/attachment.sig>


More information about the U-Boot mailing list