[PATCH 1/2] cmd: thordown: Add proper dependency for CMD_THOR_DOWNLOAD

Tom Rini trini at konsulko.com
Sat Jul 15 17:04:50 CEST 2023


On Sat, Jul 15, 2023 at 11:03:53AM -0400, Tom Rini wrote:
> On Sun, Jul 09, 2023 at 07:09:57AM -0600, Ashok Reddy Soma wrote:
> 
> > When CONFIG_CMD_USB and CONFIG_USB are disabled some compilation errors
> > are seen as below.
> > 
> > cmd/thordown.o: in function `usb_gadget_initialize':
> > include/linux/usb/gadget.h:981: undefined reference to `board_usb_init'
> > cmd/thordown.o: in function `do_thor_down':
> > cmd/thordown.c:68: undefined reference to `g_dnl_unregister'
> > cmd/thordown.o: in function `usb_gadget_release':
> > include/linux/usb/gadget.h:986: undefined reference to `board_usb_cleanup'
> > cmd/thordown.o: in function `do_thor_down':
> > cmd/thordown.c:41: undefined reference to `g_dnl_register'
> > cmd/thordown.c:48: undefined reference to `thor_init'
> > cmd/thordown.c:56: undefined reference to `thor_handle'
> > gnu/aarch64/lin/aarch64-linux/bin/aarch64-linux-gnu-ld.bfd: line 4:  8485
> > Segmentation fault      (core dumped) $CC --sysroot=$LIBC
> > --no-warn-rwx-segment "$@"
> > Makefile:1779: recipe for target 'u-boot' failed
> > make: *** [u-boot] Error 139
> > make: *** Deleting file 'u-boot'
> > 
> > Add dependency of CMD_USB for CONFIG_CMD_THOR_DOWNLOAD to fix the errors.
> > 
> > Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at amd.com>
> 
> Applied to u-boot/master, thanks!

No, no I didn't apply this still, I just forgot to remove it from the
bundle before making all the applied messages.

At least I'm not also tagging a release today, sigh.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230715/76e110e0/attachment.sig>


More information about the U-Boot mailing list