[PATCH v4 29/45] x86: Enable display for QEMU 64-bit

[Simon Glass]

Hi Bin,

On Wed, 12 Jul 2023 at 23:17, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Jun 19, 2023 at 8:02 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > Enable the various options needed for display to work on the qemu-x86_64
> > board. This includes expanding the available malloc() memory in SPL,
> > since the PCI bus must be enumerated in order to find the video device.
> >
> > It also includes enabling a bloblist, so that the video parameters can be
> > passed. This is placed at address 10000 but is not needed after U-Boot
> > proper reads the information there.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> >  configs/qemu-x86_64_defconfig | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/configs/qemu-x86_64_defconfig b/configs/qemu-x86_64_defconfig
> > index f29a5aa0f813..371ca9de8429 100644
> > --- a/configs/qemu-x86_64_defconfig
> > +++ b/configs/qemu-x86_64_defconfig
> > @@ -7,6 +7,7 @@ CONFIG_MAX_CPUS=2
> >  CONFIG_SPL_DM_SPI=y
> >  CONFIG_DEFAULT_DEVICE_TREE="qemu-x86_i440fx"
> >  CONFIG_SPL_TEXT_BASE=0xfffd0000
> > +CONFIG_SPL_SYS_MALLOC_F_LEN=0x2000
> >  CONFIG_DEBUG_UART_BASE=0x3f8
> >  CONFIG_DEBUG_UART_CLOCK=1843200
> >  CONFIG_X86_RUN_64BIT=y
> > @@ -29,7 +30,10 @@ CONFIG_SYS_CONSOLE_INFO_QUIET=y
> >  CONFIG_DISPLAY_BOARDINFO_LATE=y
> >  CONFIG_LAST_STAGE_INIT=y
> >  CONFIG_PCI_INIT_R=y
> > +CONFIG_BLOBLIST=y
> > +CONFIG_BLOBLIST_ADDR=0x10000
> >  CONFIG_SPL_NO_BSS_LIMIT=y
> > +CONFIG_SPL_BOARD_INIT=y
>
> Use this option to control not initializing serial in SPL is not
> appropriate. See comments in patch #26

Yes, OK, I fixed that patch. But we do need this one so that video starts up.

>
> >  CONFIG_SPL_SYS_MALLOC_SIMPLE=y
> >  CONFIG_SPL_CPU=y
> >  CONFIG_SPL_ENV_SUPPORT=y
> > @@ -69,10 +73,12 @@ CONFIG_LBA48=y
> >  CONFIG_SYS_64BIT_LBA=y
> >  CONFIG_CPU=y
> >  CONFIG_NVME_PCI=y
> > +CONFIG_SPL_PCI_PNP=y
> >  CONFIG_SPL_DM_RTC=y
> >  CONFIG_SYS_NS16550_PORT_MAPPED=y
> >  CONFIG_SPI=y
> >  CONFIG_USB_KEYBOARD=y
> > +CONFIG_SPL_VIDEO=y
> >  CONFIG_FRAMEBUFFER_SET_VESA_MODE=y
> >  CONFIG_FRAMEBUFFER_VESA_MODE_USER=y
> >  CONFIG_FRAMEBUFFER_VESA_MODE=0x144
> > --
>
> Otherwise,
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> Regards,
> Bin

Regards,
Simon