[PATCH v3 16/81] buildman: Just display a single line for missing maintainers

Simon Glass sjg at chromium.org
Sun Jul 16 02:35:44 CEST 2023


At present we get multiple lines of output when a board has no MAINTAINERS
entry:

   WARNING: no status info for 'bananapi-m2-pro'
   WARNING: no maintainers for 'bananapi-m2-pro'

Suppress the 'status' one since it is implied by the other.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

Changes in v3:
- Add new patch to display a single line for missing maintainers

 tools/buildman/boards.py    | 8 ++++++--
 tools/buildman/func_test.py | 1 -
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/tools/buildman/boards.py b/tools/buildman/boards.py
index 8aea6cf2dea6..25fa167b7bed 100644
--- a/tools/buildman/boards.py
+++ b/tools/buildman/boards.py
@@ -772,8 +772,12 @@ class Boards:
 
         for i, params in enumerate(params_list):
             target = params['target']
-            params['status'] = database.get_status(target)
-            params['maintainers'] = database.get_maintainers(target)
+            maintainers = database.get_maintainers(target)
+            params['maintainers'] = maintainers
+            if maintainers:
+                params['status'] = database.get_status(target)
+            else:
+                params['status'] = '-'
             params_list[i] = params
         return database.warnings
 
diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py
index 1994e42d15c8..7f21746792b6 100644
--- a/tools/buildman/func_test.py
+++ b/tools/buildman/func_test.py
@@ -920,7 +920,6 @@ Active  aarch64     armv8 - armltd total_compute board2
         self.assertEquals(2, len(params_list))
         self.assertEquals(
             ['WARNING: boards/board0/MAINTAINERS: missing defconfig ending at line 4',
-             "WARNING: no status info for 'board0'",
              "WARNING: no maintainers for 'board0'"], warnings)
 
         # Remove the maintainer line (M:) from a file (this should be fine)
-- 
2.41.0.455.g037347b96a-goog



More information about the U-Boot mailing list