[PATCH v7 05/23] j721e: dts: binman: Package tiboot3.bin, sysfw.itb, tispl.bin, u-boot.img

[Nishanth Menon]

On 13:21-20230717, Neha Malcom Francis wrote:
> Hi Nishanth
> 
> On 17/07/23 11:41, Neha Malcom Francis wrote:
> > Hi Nishanth,
> > 
> > On 15/07/23 12:00, Neha Malcom Francis wrote:
> > > Hi Nishanth
> > > 
> > > On 15/07/23 11:44, Nishanth Menon wrote:
> > > > On 19:20-20230714, Neha Malcom Francis wrote:
> > > > 
> > > > Since you are going to respin anyways, I will complain about this:
> > > > 
> > > > > +#ifdef CONFIG_TARGET_J721E_A72_EVM
> > > > > +
> > > > > +#define SPL_NODTB "spl/u-boot-spl-nodtb.bin"
> > > > > +#define SPL_J721E_EVM_DTB "spl/dts/k3-j721e-common-proc-board.dtb"
> > > > > +#define SPL_J721E_SK_DTB "spl/dts/k3-j721e-sk.dtb"
> > > > > +
> > > > > +#define UBOOT_NODTB "u-boot-nodtb.bin"
> > > > > +#define J721E_EVM_DTB "arch/arm/dts/k3-j721e-common-proc-board.dtb"
> > > > > +#define J721E_SK_DTB "arch/arm/dts/k3-j721e-sk.dtb"
> > > > > +
> > > > 
> > > > I was trying to add beaglebone-ai64 support and discovered that this
> > > > messes the reuse of j721e-binman.dtsi for ai64. I am forced to introduce
> > > > j721e-sk.dtb - so why not just use SPL_NODTB SPL_J721E_BOARD_DTB,
> > > > UBOOT_NODTB J721E_EVM_BOARD_DTB (generic names) and drop the specific sk
> > > > stuff? And define the macros in the board.dtsi prior to including the
> > > > files?
> > > > 
> > > I can do that, yes. Thanks for catching this.
> > > 
> > 
> > I'd like to just bring up that this would mean that the same A72 build
> > and binaries will no longer work for both EVM and SK, rather will have
> > to modify the CONFIG_DEFAULT_DEVICE_TREE for each. I am okay with this,
> > but just putting it out there.
> > 
> 
> An even better way would be to use the binman substitutions feature in FIT
> [1] to resolve both the beaglebone-ai64 not needing to have j721e-sk.dtb as
> well as continue having the same defconfig build supporting both J721E EVM
> as well as SK. I will work on this approach first.
> 
> [1] https://u-boot.readthedocs.io/en/latest/develop/package/entries.html#substitutions
> 

Thanks for pointing this out - will follow your lead once the new rev is
posted and will try to add beagles behind the same.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D