[PATCH V6 10/10] common: Kconfig: Fix CMD_BMP/BMP dependency

Nikhil M Jain n-jain1 at ti.com
Tue Jul 18 10:57:36 CEST 2023


From: Samuel Dionne-Riel <samuel at dionne-riel.com>

Using `default y` will not select BMP when CMD_BMP has been enabled, if
it was already configured.

By using `select`, if `CMD_BMP` is turned on, it will force the presence
of `BMP`.

Fixes: 072b0e16c4 ("common: Kconfig: Add BMP configs")
Signed-off-by: Samuel Dionne-Riel <samuel at dionne-riel.com>
Signed-off-by: Nikhil M Jain <n-jain1 at ti.com>
---
V6 (patch introduced):
- Fix CMD_BMP/BMP dependency.

 cmd/Kconfig    | 1 +
 common/Kconfig | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index c1941849f9..de7a27a86a 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1989,6 +1989,7 @@ config CMD_2048
 config CMD_BMP
 	bool "Enable 'bmp' command"
 	depends on VIDEO
+	select BMP
 	help
 	  This provides a way to obtain information about a BMP-format image
 	  and to display it. BMP (which presumably stands for BitMaP) is a
diff --git a/common/Kconfig b/common/Kconfig
index 42baca20a6..ba08fbfedf 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -1158,7 +1158,6 @@ config IO_TRACE
 
 config BMP
 	bool "Enable bmp image display"
-	default y if CMD_BMP
 	help
 	  Enable bmp functions to display bmp image and get bmp info.
 
-- 
2.34.1



More information about the U-Boot mailing list