[PATCH v2 0/7] binman: Show missing blob message when building U-Boot

Jonas Karlman jonas at kwiboo.se
Tue Jul 18 22:34:31 CEST 2023


binman currently support showing a helpful missing blob message, however
only when the badly named --allow-missing flag is used.

This changes so that binman is invoked with the --allow-missing flag
and the helpful message can be shown by default when building U-Boot.

Using the following:

  make rockpro64-rk3399_defconfig
  make CROSS_COMPILE="aarch64-linux-gnu-"

Before this series a build fails with:

  binman: Filename 'atf-bl31' not found in input path (...)

After this series a build fails with:

  Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31

  /binman/simple-bin/fit/images/@atf-SEQ/atf-bl31 (atf-bl31):
     See the documentation for your board. You may need to build ARM Trusted
     Firmware and build with BL31=/path/to/bl31.bin

  Image 'simple-bin' is missing optional external blobs but is still functional: tee-os

  /binman/simple-bin/fit/images/@tee-SEQ/tee-os (tee-os):
     See the documentation for your board. You may need to build Open Portable
     Trusted Execution Environment (OP-TEE) and build with TEE=/path/to/tee.bin

  Some images are invalid

Builds will continue to fail when there is missing blobs, and the use of
BINMAN_ALLOW_MISSING=1 now only enables the --ignore-missing flag.

Changes in v2:
- Drop merged patches.
- Add patches to improve help text.
- Add tests.
- Collect r-b tags.

In v1 there was discussion regarding the name of binman --ignore-missing
flag, see [1]. The flag is kept as-is in v2 and a rename or change of
default behavior is something that someone can do in a follow up series.

The series is based on top of Simon's "binman: Simple templating feature
and mkimage conversion" v5 series. This series can also be found at [2].

[1] https://patchwork.ozlabs.org/project/uboot/patch/20230219220158.4160763-10-jonas@kwiboo.se/
[2] https://github.com/Kwiboo/u-boot-rockchip/commits/binman-missing-v2

Jonas Karlman (7):
  binman: Update tee-os missing blob help text
  binman: Update missing optional external blob warning text
  binman: Report missing external blobs using error level
  binman: Override CheckOptional in fit entry
  binman: Fix blank line usage for invalid images warning text
  binman: Show filename in missing blob help message
  Makefile: Show binman missing blob message

 Makefile                                 |  2 +-
 tools/binman/control.py                  | 34 +++++++++++++++---------
 tools/binman/etype/fit.py                |  7 +++++
 tools/binman/ftest.py                    | 11 +++++++-
 tools/binman/missing-blob-help           |  2 +-
 tools/binman/test/264_tee_os_opt_fit.dts |  1 +
 6 files changed, 41 insertions(+), 16 deletions(-)

-- 
2.41.0



More information about the U-Boot mailing list