[PATCH v2 2/7] binman: Update missing optional external blob warning text

[Simon Glass]

On Tue, 18 Jul 2023 at 14:34, Jonas Karlman <jonas at kwiboo.se> wrote:
>
> Make it more clear that the missing external blob is optional in the
> printed warning message.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
> ---
> v2:
> - New patch
>
>  tools/binman/control.py | 2 +-
>  tools/binman/ftest.py   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/binman/control.py b/tools/binman/control.py
> index 25e66814837d..3560cadba4c2 100644
> --- a/tools/binman/control.py
> +++ b/tools/binman/control.py
> @@ -674,7 +674,7 @@ def ProcessImage(image, update_fdt, write_map, get_contents=True,
>      image.CheckOptional(optional_list)
>      if optional_list:
>          tout.warning(
> -            "Image '%s' is missing external blobs but is still functional: %s" %
> +            "Image '%s' is missing optional external blobs but is still functional: %s" %
>              (image.name, ' '.join([e.name for e in optional_list])))
>          _ShowHelpForMissingBlobs(optional_list)
>
> diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
> index e53181afb78a..152f800c676c 100644
> --- a/tools/binman/ftest.py
> +++ b/tools/binman/ftest.py
> @@ -6330,7 +6330,7 @@ fdt         fdtmap                Extract the devicetree blob from the fdtmap
>          err = stderr.getvalue()
>          self.assertRegex(
>              err,
> -            "Image '.*' is missing external blobs but is still functional: missing")
> +            "Image '.*' is missing optional external blobs but is still functional: missing")
>
>      def testSectionInner(self):
>          """Test an inner section with a size"""
> --
> 2.41.0
>

Reviewed-by: Simon Glass <sjg at chromium.org>