[PATCH 04/29] spi: mtk_spim: clear IRQ enable bits

Weijie Gao weijie.gao at mediatek.com
Wed Jul 19 11:16:02 CEST 2023

In u-boot we don't use IRQ. Instead, we poll busy bit in SPI_STATUS.

However these IRQ enable bits may be set in previous boot stage (BootROM).

If we leave these bits not cleared, although u-boot has disabled IRQ and
nothing will happen, the linux kernel may encounter panic during
initializing the spim driver due to IRQ event happens before IRQ handler
is properly setup.

This patch clear IRQ bits to prevent this from happening.

Signed-off-by: SkyLake.Huang <skylake.huang at mediatek.com>
Signed-off-by: Weijie Gao <weijie.gao at mediatek.com>
 drivers/spi/mtk_spim.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/spi/mtk_spim.c b/drivers/spi/mtk_spim.c
index 3a742d160c..418e586b91 100644
--- a/drivers/spi/mtk_spim.c
+++ b/drivers/spi/mtk_spim.c
@@ -242,6 +242,9 @@ static int mtk_spim_hw_init(struct spi_slave *slave)
 			reg_val &= ~SPI_CMD_SAMPLE_SEL;
+	/* Disable interrupt enable for pause mode & normal mode */
 	/* disable dma mode */
 	reg_val &= ~(SPI_CMD_TX_DMA | SPI_CMD_RX_DMA);

More information about the U-Boot mailing list